Menu
Community /Pin to ProfileBookmark
@NogDogDec 08.2010 — #I prefer to keep them in separate files. One main reason is that it allows for the use of __autoload() to load class definitions as needed rather than having to manually code a require_once() for each class file.
For organization, you can use a naming convention where you use "_" in the class names to indicate a hierarchy, which is mirrored in your class file directory structure (similar to the PEAR directory structure). So your abstract class might be named "HotelRoom" while your concrete classes would be "HotelRoom_Single" and "HotelRoom_Double". Then your files would be set up as:
Then your __autoload() function would be something like:
@NogDogDec 08.2010 — #In some cases it might be slower, but in other cases it might be faster. If you have a file with, say, 5 class definitions in it [i]and[/i] your script is going to use all 5 of them, it might be a little faster than 5 separate files. (With modern disk drives and disk caches, this may be a very small difference, though.) But what if a given script uses only 2 of the 5 classes? Now you are loading, parsing, and processing 3 unused classes, which may well take more time than the whatever you saved (if anything) by loading only one file instead of 2.
I guess it's just one of those performance things that I don't worry about, instead concentrating on things like database/query optimization and overall script logic which -- outside of the HTTP request lags -- probably have a much bigger performance impact in most web apps. If you're in a situation where you need to worry about a few milliseconds (or microseconds), then you probably should be using C# or such to create compiled executables. ? Unless/until I encounter a situation where I really have to worry about such tiny performance tweaks, I prefer to design my apps to save [i]me[/i] time rather than that multi-gigabyte CPU. ?
Class Organisation
Hi, I have read from a few places that it is a best practice to keep each class in a separate file, e.g. class hotelRoom would be in hotelRoom.php or hotelRoom.class.php.
However when you start to read about design patterns and using polymorphism etc this gets a bit complicated. e.g.
[code=php]
abstract class hotelRoom{
private $cost;
}
class singleRoom extends hotelRoom{
}
class doubleRoom extends hotelRoom{
}
I do not really want to put all of these classes in their own separate file. Does anybody have an idea of the best practice for doing stuff like this?
I have been thinking of putting every class and interface etc that is related to the hotelRoom in a single php file, is this bad practice?
Thanks in advance
Sign in
to post a comment6 Comments(s) ↴
0
@NogDogDec 08.2010 — #I prefer to keep them in separate files. One main reason is that it allows for the use of __autoload() to load class definitions as needed rather than having to manually code a require_once() for each class file.For organization, you can use a naming convention where you use "_" in the class names to indicate a hierarchy, which is mirrored in your class file directory structure (similar to the PEAR directory structure). So your abstract class might be named "HotelRoom" while your concrete classes would be "HotelRoom_Single" and "HotelRoom_Double". Then your files would be set up as:
<i>
</i>classes/HotelRoom.php
classes/HotelRoom/Single.php (class name: HotelRoom_Single)
classes/HotelRoom/Double.php (class name: HotelRoom_Double)
Then your __autoload() function would be something like:
[code=php]
function __autoload($class)
{
require $_SERVER['DOCUMENT_ROOT'].'/classes/'.str_replace('_', '/', $class).'.php';
}
[/code]0
@NogDogDec 08.2010 — #In some cases it might be slower, but in other cases it might be faster. If you have a file with, say, 5 class definitions in it [i]and[/i] your script is going to use all 5 of them, it might be a little faster than 5 separate files. (With modern disk drives and disk caches, this may be a very small difference, though.) But what if a given script uses only 2 of the 5 classes? Now you are loading, parsing, and processing 3 unused classes, which may well take more time than the whatever you saved (if anything) by loading only one file instead of 2.I guess it's just one of those performance things that I don't worry about, instead concentrating on things like database/query optimization and overall script logic which -- outside of the HTTP request lags -- probably have a much bigger performance impact in most web apps. If you're in a situation where you need to worry about a few milliseconds (or microseconds), then you probably should be using C# or such to create compiled executables. ? Unless/until I encounter a situation where I really have to worry about such tiny performance tweaks, I prefer to design my apps to save [i]me[/i] time rather than that multi-gigabyte CPU. ?