Menu
Community /Pin to ProfileBookmark
@NogDogJul 28.2005 — #Another way to go about this would be to build a data structure:
I like this over a whole bunch of if/else statements, because it keeps all the data in one place and easier to read, so that if you add data or want to rearrange it, it's easier to do.
PS: "<>" is the same as "!=" in PHP, it does not specify a range of numbers.@NogDogJul 28.2005 — #I think so (it's all a lot to try to take in at once ? ). Only change I would make is the checks at the end of my code. Instead of this...
...just do something like this (I'm just trying to handle unforeseen error situations)...
...replacing the link I used above with whatever you would like to be the default link in case something odd happens (like a curious/malicious/stupid user types in some strange value in the URL).@NogDogJul 29.2005 — #I copied that $i variable from your original code, but I'm not seeing anywhere that it's being set, so that would probably explain it. I guess I assumed you were setting it somewhere from a GET or POST value? If that's the plan, then all you need to do is set $i equal to that value (such as [color=blue][b]$i = $_GET['key'];[/b][/color] where 'key' is the name of the incoming GET value (or use $_POST if it's from a post-method form) before you do much of anything else in the script.
More Variable URL woes.
My array so far…
[code=php]<?php
include(“../../inserts/head.htm”);
echo(”
<link type=”text/css” rel=”stylesheet” href=”../../setup.css”>
“);
$inserts=array(“comic000.htm”,”comic001.htm”, “comic002.htm”, (200+ inserts) “comic232.htm”, “comic233.htm”, “comic234.htm”);
$max = count($inserts); // get total inserts
if ($i =0<>1) {$chronologylink=”../../chronology.php?semester=0″;}
else if ($i =2<>4) {$chronologylink=”../../chronology.php?semester=1&month=0″;}
else if ($i =5<>22) {$chronologylink=”../../chronology.php?semester=1&month=1″;}
else if ($i =23<>41) {$chronologylink=”../../chronology.php?semester=1&month=2″;}
else if ($i =42<>58) {$chronologylink=”../../chronology.php?semester=1&month=3″;}
else if ($i =59<>68) {$chronologylink=”../../chronology.php?semester=2&month=0″;}
else if ($i =69<>88) {$chronologylink=”../../chronology.php?semester=2&month=1″;}
else if ($i =89<>96) {$chronologylink=”../../chronology.php?semester=2&month=2″;}
else if ($i =97<>113) {$chronologylink=”../../chronology.php?semester=2&month=3″;}
else if ($i =114<>115) {$chronologylink=”../../chronology.php?semester=3&month=0″;}
else if ($i =116<>135) {$chronologylink=”../../chronology.php?semester=3&month=1″;}
else if ($i =136<>154) {$chronologylink=”../../chronology.php?semester=3&month=2″;}
else if ($i =155<>173) {$chronologylink=”../../chronology.php?semester=3&month=3″;}
else if ($i =174<>176) {$chronologylink=”../../chronology.php?semester=3&month=4″;}
else if ($i =177<>188) {$chronologylink=”../../chronology.php?semester=4&month=0″;}
else if ($i =189<>206) {$chronologylink=”../../chronology.php?semester=4&month=1″;}
else if ($i =207<>218) {$chronologylink=”../../chronology.php?semester=4&month=2″;}
else if ($i =219<>234) {$chronologylink=”../../chronology.php?semester=4&month=3″;}
$i = (isset($_GET[‘page’])) ? $_GET[‘page’] : 0;
$iprev = ($i == 0) ? “./comic-first.php” : “comics.php?page=” . ($i – 1);
$inext = ($i == $max -1) ? “./comic-last.php” : “comics.php?page=” . ($i +1);
include $inserts [$i]; ?>
<ul id=”comiclink”>
<li><a href=”comic-first.php”>First</a></li>
<a href=”<?php echo $iprev; ?>”>Previous</a></li>
<li><a href=”../../index.php”>Back to Main</a></li>
<li><a href=”<?php echo $chronologylink; ?>”>Back to Chronology</a></li>
<a href=”<?php echo $inext; ?>”>Next</a></li>
<li><a href=”comics.php?page=<?php echo $max – 1; ?>”>Last</a></li>
</ul>
</body>
</html>
Now, what happens with my Back to Chronology link is this:
If I have the “else”s in the [i]else if ($i =#<>#) {$chronologylink=”../../chronology.php?semester=#&month=#”;}[i]$chronologylink[i]../../chronology.php?semester=0″
If I don’t have the “else”s in, then [i]$chronologylink[i]../../chronology.php?semester=4&month=3″
Where am I going wrong?
Sign in
to post a comment12 Comments(s) ↴
0
@NogDogJul 28.2005 — #Another way to go about this would be to build a data structure:[code=php]
$urls =
array(
array('min'=>0, 'max'=>1, 'semester'=>0, 'month'=>NULL),
array('min'=>2, 'max'=>4, 'semester'=>1, 'month'=>0),
array('min'=>5, 'max'=>22, 'semester'=>1, 'month'=>1),
array('min'=>23, 'max'=>41, 'semester'=>1, 'month'=>2),
array('min'=>42, 'max'=>58, 'semester'=>1, 'month'=>3),
array('min'=>59, 'max'=>68, 'semester'=>2, 'month'=>0),
array('min'=>69, 'max'=>88, 'semester'=>2, 'month'=>1),
array('min'=>89, 'max'=>96, 'semester'=>2, 'month'=>2),
array('min'=>97, 'max'=>113, 'semester'=>2, 'month'=>3),
array('min'=>114, 'max'=>115, 'semester'=>3, 'month'=>0),
array('min'=>116, 'max'=>135, 'semester'=>3, 'month'=>1),
array('min'=>136, 'max'=>154, 'semester'=>3, 'month'=>2),
array('min'=>155, 'max'=>173, 'semester'=>3, 'month'=>3),
array('min'=>174, 'max'=>176, 'semester'=>3, 'month'=>4),
array('min'=>177, 'max'=>188, 'semester'=>4, 'month'=>0),
array('min'=>189, 'max'=>206, 'semester'=>4, 'month'=>1),
array('min'=>207, 'max'=>218, 'semester'=>4, 'month'=>2),
array('min'=>219, 'max'=>234, 'semester'=>4, 'month'=>3)
);
$found = FALSE;
foreach($urls as $key => $val)
{
if($i >= $urls[$key]['min'] and $i <= $urls[$key]['max'])
{
$found = TRUE;
$chronologylink="../../chronology.php?semester=".$urls[$key]['semester'];
if(!empty($urls[$key]['month']))
{
$chronologylink .= "&month=".$urls[$key]['month'];
}
break;
}
}
if(!$found)
{
# $i wasn't found in the array, so you need error-handling here
}
else
{
# found it, so $chronologylink is now ready to use
}
[/code]I like this over a whole bunch of if/else statements, because it keeps all the data in one place and easier to read, so that if you add data or want to rearrange it, it's easier to do.
PS: "<>" is the same as "!=" in PHP, it does not specify a range of numbers.
0
@NogDogJul 28.2005 — #I think so (it's all a lot to try to take in at once ? ). Only change I would make is the checks at the end of my code. Instead of this...[code=php]
if(!$found)
{
# $i wasn't found in the array, so you need error-handling here
}
else
{
# found it, so $chronologylink is now ready to use
}
[/code]...just do something like this (I'm just trying to handle unforeseen error situations)...
[code=php]
if(!$found)
{
$chronologylink = "../../chronology.php"
}
[/code]...replacing the link I used above with whatever you would like to be the default link in case something odd happens (like a curious/malicious/stupid user types in some strange value in the URL).
0
@NogDogJul 29.2005 — #I copied that $i variable from your original code, but I'm not seeing anywhere that it's being set, so that would probably explain it. I guess I assumed you were setting it somewhere from a GET or POST value? If that's the plan, then all you need to do is set $i equal to that value (such as