Menu
Community /Pin to ProfileBookmark
@NogDogDec 03.2016 — #Question: what is the format of the [FONT=Courier New][COLOR="#B22222"][B]$custom_name_colour[/B][/COLOR] [/FONT] string? By any chance do you need to prepend [B][FONT=Courier New][COLOR="#B22222"]color:[/COLOR] [/FONT][/B] to it?@NogDogDec 03.2016 — #Just eye-balling your code, it looks logical to me, though the <font> HTML tag has been deprecated for a long time. In any case, I'd be tempted to use sprintf() to tighten things up a bit structurally (untested):
@NogDogDec 03.2016 — #PS, for that matter, the <span> seems superfluous. You could just do:
Font class in concatenated variable
I originally posted this on StackOverflow, but it ended up getting completely ignored there.
Original text:
I am trying to concatenate a couple of things into 1 variable, to make MySQL’s life easier.
However, this only works as it’s supposed to if people have a custom name colour applied.
People who don’t will appear as the default “a” (for URLs) class as specified in CSS.
For example, I have the following thing in PHP:
[code=php]$name = “<a href=’user.php?page=profile&uid=$uid’>”;
if (empty($custom_name_colour)) {
$name .= “<font style=’color: #7C60B0;’>”;
}
else {
$name .= “<span style=’$custom_name_colour’>”;
}
if (empty($display_name)) {
$name .= $username;
}
else {
$name .= $display_name;
}
if (empty($custom_name_colour)) {
$name .= “</font>”;
}
else {
$name .= “</span>”;
}
$name .= “</a>”;
The font style is actually being determined though a function based on the users’ gender and power level, but I chose one of them to make this question a bit more testable.
Sign in
to post a comment5 Comments(s) ↴
0
@NogDogDec 03.2016 — #Question: what is the format of the [FONT=Courier New]0
@NogDogDec 03.2016 — #Just eye-balling your code, it looks logical to me, though the <font> HTML tag has been deprecated for a long time. In any case, I'd be tempted to use sprintf() to tighten things up a bit structurally (untested):[code=php]
$name = sprintf(
"<a href='user.php?page=profile&uid=%d'><span style='%s'>%s</span></a>",
$uid,
empty($custom_name_colour) ? 'color: #7C60B0' : $custom_name_colour,
empty($display_name) ? $username : $display_name
);
[/code]0
@NogDogDec 03.2016 — #PS, for that matter, the <span> seems superfluous. You could just do:[code=php]
$name = sprintf(
"<a href='user.php?page=profile&uid=%d' style='%s'>%s</a>",
$uid,
empty($custom_name_colour) ? 'color: #7C60B0' : $custom_name_colour,
empty($display_name) ? $username : $display_name
);
[/code] (still untested)