Menu
Community /Pin to ProfileBookmark
@NogDogOct 27.2014 — #My guess is that you are retrieving empty lines from the file. Maybe try this:
Though it would still probably be a good idea to put some defensive code in after that to make sure that any given random line you then grab actually explode()'s into the required number of fields before you try to access them.@NogDogOct 27.2014 — #So it's likely the lines you are reading in from the file (or at least some of them) do not have 4 pipe-delimited fields in them (since you are explode()-ing on "|"). If that is possible, then you need to decide how to handle it: output an error, terminate this part of the processing and just don't output it, throw an exception, whatever. You might do something like:
[RESOLVED] Several PHP Undefined offset errors
I am getting the following errors to a random quote script I have:
[CODE]PHP Notice: Undefined offset: 3 in /home1/shamaror/includesem/lgrquote.php on line 58
PHP Notice: Undefined offset: 2 in /home1/shamaror/includesem/lgrquote.php on line 58
PHP Notice: Undefined offset: 1 in /home1/shamaror/includesem/lgrquote.php on line 58
PHP Notice: Undefined offset: 3 in /home1/shamaror/includesem/lgrquote.php on line 58
PHP Notice: Undefined offset: 2 in /home1/shamaror/includesem/lgrquote.php on line 58
PHP Notice: Undefined offset: 1 in /home1/shamaror/includesem/lgrquote.php on line 58
I don’t know too much about PHP, especially this type of problem. Any suggestions?
[CODE]$quotetitle=””;
$quotefile=”quotes.txt”;
$dir=$_SERVER[‘DOCUMENT_ROOT’];
//No need to change anything below here.
if (file_exists($dir.”/”.$quotefile)) {
$quote=file($dir.”/”.$quotefile);
$rand_key=array_rand($quote, 1);
list($qtext, $qauthor, $qlink, $qlinktext) = explode(“|”, trim($quote[$rand_key]));
if (isset($qtext) && $qtext!=””) { echo $qtext; }
}
?>
Sign in
to post a comment8 Comments(s) ↴
0
@NogDogOct 27.2014 — #My guess is that you are retrieving empty lines from the file. Maybe try this:[code=php]
if (file_exists($dir."/".$quotefile)) {
$quote=file($dir."/".$quotefile, FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES); // added 2 flags
$rand_key=array_rand($quote, 1);
[/code]Though it would still probably be a good idea to put some defensive code in after that to make sure that any given random line you then grab actually explode()'s into the required number of fields before you try to access them.
0
@NogDogOct 27.2014 — #So it's likely the lines you are reading in from the file (or at least some of them) do not have 4 pipe-delimited fields in them (since you are explode()-ing on "|"). If that is possible, then you need to decide how to handle it: output an error, terminate this part of the processing and just don't output it, throw an exception, whatever. You might do something like:[code=php]
if (file_exists($dir."/".$quotefile)) {
$quote=file($dir."/".$quotefile, FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES); // added 2 flags
$rand_key=array_rand($quote, 1);
$data = explode("|", trim($quote[$rand_key]));
if(count($data) < 4) {
list($qtext, $qauthor, $qlink, $qlinktext) = $data;
}
else {
// here's where you handle the error condition
}
}
[/code]