Menu
Community /Pin to ProfileBookmark
@NogDogOct 24.2014 — #Public service announcement: you should not be using mysql_*() functions any more, use MySQLi or PDO instead.
Anyway, per the manual:
Since you are doing an insert statement, there is nothing gained by that if/else block, you could just directly return the result of the mysql_query() call. As to why, it appears the function is designed to return a Boolean result, with true indicating successful insert, otherwise a false indicates the insert did not occur (for one reason or another). Some people do not like to have multiple exit points in their functions, so you could get around that with something like the following:
Whats with the return true and return false ??
Given the following code :
[code=php]
function send_msg($sender , $message){
if(!empty($sender) && !empty($message)){
$sender = mysql_real_escape_string($sender);
$message= mysql_real_escape_string($message);
$query = “INSERT INTO `chat`.`chat` VALUES (null , ‘{$sender}’ , ‘$message’)”;
if($run = mysql_query($query)){
return true;
}else{
return false;
}
}
else{
return false;
}
}
What if i do just this in the end : (i.e take off the return true and return false)
[code=php]
$run = mysql_query($query)
what is the implecation of not typing in the return true and return false ??
Sign in
to post a comment2 Comments(s) ↴
0
@NogDogOct 24.2014 — #Public service announcement: you should not be using mysql_*() functions any more, use MySQLi or PDO instead.Anyway, per the manual:
Return Values ¶
For SELECT, SHOW, DESCRIBE, EXPLAIN and other statements returning resultset, mysql_query() returns a resource on success, or FALSE on error.
For other type of SQL statements, INSERT, UPDATE, DELETE, DROP, etc, mysql_query() returns TRUE on success or FALSE on error. [/quote]
Since you are doing an insert statement, there is nothing gained by that if/else block, you could just directly return the result of the mysql_query() call. As to why, it appears the function is designed to return a Boolean result, with true indicating successful insert, otherwise a false indicates the insert did not occur (for one reason or another). Some people do not like to have multiple exit points in their functions, so you could get around that with something like the following:
[code=php]
function send_msg($sender , $message){
$result = false;
if(!empty($sender) && !empty($message)){
$sender = mysql_real_escape_string($sender);
$message= mysql_real_escape_string($message);
$query = "INSERT INTO chat.chat VALUES (null , '{$sender}' , '$message')";
$result = mysql_query($query));
}
return $result; // only exit point
}
[/code]