Menu
Community /Pin to ProfileBookmark
@NogDogAug 30.2014 — #
It's optional in the old mysql_*() functions -- it will pick the last(?)/only connection if there is one.
Anyway, while I would hope you would migrate away from the old and deprecated mysql extension as the others have recommended, if you stay with this code, you should be using mysql_real_escape_string() to sanitize values [i]before[/i] using them in mysql_query(), not [i]afterwards[/i] for data retrieved from the DB.
New web host, php form not working
I changed web hosting companies and now a php form that was working is no longer working. I haven’t been able to figure out what the problem is. The form is a simple text input form that adds the text to a database. Every time the user inserts text with a comma, an error occurs. Below is the code for the form. Any help is much appreciated.
[code=php]<!DOCTYPE html PUBLIC “-//W3C//DTD XHTML 1.0 Transitional//EN” “http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd”>
<html xmlns=”http://www.w3.org/1999/xhtml”>
<head>
<meta http-equiv=”Content-Type” content=”text/html; charset=utf-8″ />
<title></title>
<link href=”style.css” rel=”stylesheet” type=”text/css” />
</head>
<body>
<?php require_once(‘inc/header.html’); ?>
<?php require_once(‘../Connections/websitedatabase.php’); ?>
<?php
if (isset($_POST[‘note’])):
$note = $_POST[‘note’];
$name = $_POST[‘name’];
$id = $_POST[‘id’];
$sql = “UPDATE presidentnotes SET
note=’$note’,
name=’$name’
“;
if (@mysql_query($sql)) {
echo ‘<p>The note has been updated.</p>’;
} else {
echo ‘<p>Error updating note. Details: ‘ .
mysql_error() . ‘</p>’;
}
?>
<?php
else:
$presidentnotes = @mysql_query(
“SELECT note, name FROM presidentnotes “);
if (!$presidentnotes) {
exit(‘<p>Error fetching note details: ‘ .
mysql_error() . ‘</p>’);
}
$presidentnotes = mysql_fetch_array($presidentnotes);
$note = $presidentnotes[‘note’];
$name = $presidentnotes[‘name’];
$note = mysql_real_escape_string($note);
$name = mysql_real_escape_string($name);
?>
<form action=”<?php echo $_SERVER[‘PHP_SELF’]; ?>” method=”post”>
<h1>President’s Note on hompage – Edit5</h1>
<label>Note:<br />
<textarea name=”note” cols=”100″ rows=”12″><?php echo $note; ?></textarea>
</label><br />
<label>Name:<br /> <input name=”name” type=”text” value=”<?php echo $name; ?>” size=”40″ /></label><br />
<input type=”hidden” name=”id” value=”<?php echo $id; ?>” />
<input type=”submit” value=”SUBMIT” /></p>
</form>
<p>
<?php endif; ?>
<p> </p>
</body>
</html>
Sign in
to post a comment5 Comments(s) ↴
0
@NogDogAug 30.2014 — #...
mysql_query($sql) is missing a parameter, your $link to your database that you get from your connection.
...[/QUOTE]
It's optional in the old mysql_*() functions -- it will pick the last(?)/only connection if there is one.
Anyway, while I would hope you would migrate away from the old and deprecated mysql extension as the others have recommended, if you stay with this code, you should be using mysql_real_escape_string() to sanitize values [i]before[/i] using them in mysql_query(), not [i]afterwards[/i] for data retrieved from the DB.