Menu
Community /Pin to ProfileBookmark
@NogDogJan 11.2014 — #Well, my first thought is that if you are going to use prepared statements and bound parameters with PDO (which is a very good thing), then you should have no issues with sanitizing values for SQL use. Therefore, the only thing you would need your SanitizeText class is for issues not related to SQL/database stuff. If that's the case, then I would not inject that dependency into your Database class, as you want classes to stay narrowly focused on their specific purposes.
If your SanitizeText class is designed for other things (e.g. screening out link or JavaScript injection), that would probably better fit wherever you would do things like form validation and so forth, not in your database class.
If we set all that aside and assume for now that you do have a reason for using that class within your Database class, probably the best way to make that dependency obvious is to inject it directly via the constructor. That way any client code "knows" it has to provide it.
Oh, and a database class can be a good opportunity to make use of inheritance.
Possible instantiation:
@NogDogJan 15.2014 — #What I suggest doing is to make use of PDO's ability to use bound parameters in prepared statement. When you do that, PDO takes care of any needed sanitizing all by itself -- you don't need any SQL-related sanitizing functions (untested):
[RESOLVED] How can I pass an object into PDO?
I’m new to php and am trying to learn oop. I have a simple input that passes the text to a class to sanitize it. I want to be able to insert the text into the database using pdo. I’m not sure if I’m going the correct way with this.
[code]
$sanitize = new SanitizeText($category);
//I want the sanitize text in the database.
$newdb = new Database();
[code]
class Database {
private $db_user = ‘root’;
private $db_password = ‘password’;
private $db_name = ‘test’;
private $db_host = ‘localhost’;
public $prepare_sql;
public $execute_sql;
// Connect to database
public function __construct() {
try {
new PDO(‘mysql:host=’ .$this->db_host. ‘; dbname=’ .$this->db_name, $this->db_user, $this->db_password);
echo “Connected to database”;
}
catch (PDOException $e) {
echo “Could not connect to database”;
}
}
// Insert data.. not sure if this is proper
public function create() {
$stmt = $this->prepare($prepare_sql);
$stmt->execute($execute_sql);
}
}
Sign in
to post a comment4 Comments(s) ↴
0
@NogDogJan 11.2014 — #Well, my first thought is that if you are going to use prepared statements and bound parameters with PDO (which is a very good thing), then you should have no issues with sanitizing values for SQL use. Therefore, the only thing you would need your SanitizeText class is for issues not related to SQL/database stuff. If that's the case, then I would not inject that dependency into your Database class, as you want classes to stay narrowly focused on their specific purposes.If your SanitizeText class is designed for other things (e.g. screening out link or JavaScript injection), that would probably better fit wherever you would do things like form validation and so forth, not in your database class.
If we set all that aside and assume for now that you do have a reason for using that class within your Database class, probably the best way to make that dependency obvious is to inject it directly via the constructor. That way any client code "knows" it has to provide it.
Oh, and a database class can be a good opportunity to make use of inheritance.
[code=php]
<?php
class Database extends PDO
{
private $sanitize;
private $db_user = 'root';
private $db_password = 'password';
private $db_name = 'test';
private $db_host = 'localhost';
public function __construct(SanitizeText $sanitize)
{
$this->sanitize = $sanitize;
parent::__construct(
'mysql:host=' .$this->db_host.'; dbname='.$this->db_name,
$this->db_user,
$this->db_password
);
}
public function doSomethingWith($text)
{
$text = $this->sanitize->someMethod($text);
echo "And the sanitized text is:".PHP_EOL.$text;
}
}
[/code]Possible instantiation:
[code=php]
$db = new Database(new SanitizeText());
[/code]0
@NogDogJan 15.2014 — #What I suggest doing is to make use of PDO's ability to use bound parameters in prepared statement. When you do that, PDO takes care of any needed sanitizing all by itself -- you don't need any SQL-related sanitizing functions (untested):[code=php]
<?php
class Database extends PDO
{
private $db_user = 'root';
private $db_password = 'password';
private $db_name = 'test';
private $db_host = 'localhost';
public function __construct()
{
parent::__construct(
'mysql:host=' .$this->db_host.'; dbname='.$this->db_name,
$this->db_user,
$this->db_password
);
}
/**
* Run a query that uses bound parameters
* @return PDOStatement
* @param string $sql
* @param array $data
*/
public function runQuery($sql, Array $data=null)
{
$stmt = $this->prepare($sql);
if($stmt == false) {
throw new Exception(array_merge($this->errorInfo(), array('sql' => $sql)));
}
if($stmt->execute($data) == false) {
throw new Exception(array_merge($stmt->errorInfo(), array('sql' => $sql)));
}
return $stmt;
}
}
// SAMPLE USAGE:
$db = new Database();
// note leading ":" character in parameter names in following 2 commands:
$sql = "SELECT * FROM some_table WHERE foo=:value_1 AND bar=:another_value";
$data = array(
':value_1' => $_GET['some_field'],
':another_value' => $_GET['another_field']
);
// you don't have to worry about sanitizing SQL, as PDO takes care of it for you
$stmt = $db->runQuery($sql, $data);
while($row = $stmt->fetch(PDO::FETCH_ASSOC)) {
// do stuff with values in $row
}
[/code]