/    Sign up×
Community /Pin to ProfileBookmark

I need help doing making images change

Copy linkTweet thisAlerts:
Aug 22.2013

What is wrong with this code:

[CODE]var i = 0;

function time() {
window.setInterval(change(), 5000);
}

function change() {
i++;
if (i = 1) {
document.getElementById(“slider”).src=”img/index/Image1.jpg”;
}
else if (i = 2) {
document.getElementById(“slider”).src=”img/index/Image2.jpg”;
}
else if (i = 3) {
document.getElementById(“slider”).src=”img/index/Image3.jpg”;
}
else if (i = 4) {
document.getElementById(“slider”).src=”img/index/Image4.jpg”;
}
else if (i = 5) {
document.getElementById(“slider”).src=”img/index/Image5.jpg”;
}
else if (i = 6) {
document.getElementById(“slider”).src=”img/index/Image6.jpg”;
}
else if (i = 7) {
document.getElementById(“slider”).src=”img/index/Image7.jpg”;
}
else if (i = 8) {
document.getElementById(“slider”).src=”img/index/Image8.jpg”;
}
else if (i = 9) {
document.getElementById(“slider”).src=”img/index/Image9.jpg”;
}
}[/CODE]

I need some images to change every 5 seconds. I called “time()” when the body tag loads.

to post a comment
JavaScript

3 Comments(s) ↴

Copy linkTweet thisAlerts:
@elyimmyauthorAug 22.2013 — I changed my code to:
[CODE]var i = 0;
var images = [];
images [0] = "img/index/Image1.jpg";
images [1] = "img/index/Image2.jpg";
images [2] = "img/index/Image3.jpg";
images [3] = "img/index/Image4.jpg";
images [4] = "img/index/Image5.jpg";
images [5] = "img/index/Image6.jpg";
images [6] = "img/index/Image7.jpg";
images [7] = "img/index/Image8.jpg";
images [8] = "img/index/Image9.jpg";

function time() {
var timer = setInterval(change, 2500);
}

function change() {
document.getElementById("slider").src = images[i];
i++;
if (i >= images.length) {
i = 0;
}
}[/CODE]

And it Worked!!

???
Copy linkTweet thisAlerts:
@tenfoldAug 22.2013 — Nice.

I don't want to confuse you, but if you have the images named like that, you could get rid of that array.

[CODE]var i = 1, slider;

function time() {
slider = document.getElementById('slider');
setInterval(change, 2500);
}

function change() {
slider.src = 'img/index/Image' + i + '.jpg';
i = i >= 9 ? 1 : i + 1; // may be confusing
}[/CODE]
Copy linkTweet thisAlerts:
@sugafreeMar 20.2014 — Hi everyone,

Could someone help me out on this one? The story is, I have got a fixed html code which I can not change. There is a div contaning a picture, I need to change that picture to show five other pictures randomly using getElementById.

I have got some js coding already, but couldnt manage to change that div. My ideas were like creating a new function {window.onLoad getElementById then document.write and the rest od the code for the random pics, but it wasnt working. Tried to create a new var for the Math.floor(Math.random... and then combine this together in different ways.. Nothing. I am new to JS(only 2months) anyone could help me out on this one?

Thanks

Here is the JS code I have ps that commented document.write line is working but instead of displaying it on the top, it should be in a specific div.
<i>
</i>var delay=1000; //set delay in miliseconds
var curindex=0;

var randomimages=new Array();

<i> </i>randomimages[0]="images/img06.jpg";
<i> </i>randomimages[1]="images/img07.jpg";
<i> </i>randomimages[2]="images/img08.jpg";
<i> </i>randomimages[3]="images/img09.jpg";
<i> </i>randomimages[4]="images/img10.jpg";
var preload=new Array();

for (n=0;n&lt;randomimages.length;n++)
{
preload[n]=new Image();
preload[n].src=randomimages[n];
}
function changediv ()
{
document.getElementById('splash').innerHTML=document.write('&lt;img name="splash" src="'+randomimages[Math.floor(Math.random()*(randomimages.length))]+'"&gt;');
}

// window.onload=changediv();
// window.onload=getElementById('splash'){document.write(randomimages[Math.floor(Math.random()*(randomimages.length)))};
// document.write('&lt;img name="splash" src="'+randomimages[Math.floor(Math.random()*(randomimages.length))]+'"&gt;');

function rotateimage()
{

if (curindex==(tempindex=Math.floor(Math.random()*(randomimages.length)))){
curindex=curindex==0? 1 : curindex-1;
}
else
curindex=tempindex;

<i> </i>document.images.splash.src=randomimages[curindex];
}

setInterval("rotateimage()",delay);
×

Success!

Help @elyimmy spread the word by sharing this article on Twitter...

Tweet This
Sign in
Forgot password?
Sign in with TwitchSign in with GithubCreate Account
about: ({
version: 0.1.9 — BETA 5.3,
whats_new: community page,
up_next: more Davinci•003 tasks,
coming_soon: events calendar,
social: @webDeveloperHQ
});

legal: ({
terms: of use,
privacy: policy
});
changelog: (
version: 0.1.9,
notes: added community page

version: 0.1.8,
notes: added Davinci•003

version: 0.1.7,
notes: upvote answers to bounties

version: 0.1.6,
notes: article editor refresh
)...
recent_tips: (
tipper: @Yussuf4331,
tipped: article
amount: 1000 SATS,

tipper: @darkwebsites540,
tipped: article
amount: 10 SATS,

tipper: @Samric24,
tipped: article
amount: 1000 SATS,
)...