/    Sign up×
Community /Pin to ProfileBookmark

more php assistance

Alright guys just a little more help,

below are the three pages i’m currently working with, some of it seems to be working but i’m having issues with the insert.php page, at the bottom is the results i’m seeing just need someone to guide me to resolve.

I am not getting any syntax errors at all, and all 3 files are under one folder

This is labeled index.html

[code=html]
<!DOCTYPE html PUBLIC “-//W3C//DTD XHTML 1.0 Transitional//EN” “http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd”>
<html xmlns=”http://www.w3.org/1999/xhtml”>
<head>
<meta http-equiv=”Content-Type” content=”text/html; charset=utf-8″ />
<title>Untitled Document</title>
<style type=”text/css”>
.labelclass{
float: left;
width: 150px;
}
</style>
</head>
<body>
<img src=”http://omgtechhelp.com/wp/wp-content/themes/OMGTech/images/logo7small.jpg” />
<center>
<h1><u>Notes For The Month Of August</u></h1>
</center>
<hr />
<form name=”myform” action=”insert.php” target=”_blank” method=”post”>
<span class=”labelclass” style=”font-family:’Comic Sans MS’, cursive”>Customer Name: </span><input type=”text” name=”customername” /><br />
<span class=”labelclass” style=”font-family:’Comic Sans MS’, cursive”>Phone Number: </span><input type=”tel” name=”pnumber” /><br />
<span class=”labelclass” style=”font-family:’Comic Sans MS’, cursive”>E-Mail Address: </span><input type=”text” name=”eaddy” /><br />
<span class=”labelclass” style=”font-family:’Comic Sans MS’, cursive”>Issue: </span><input type=”text” name=”issue” /><br />
<span class=”labelclass” style=”font-family:’Comic Sans MS’, cursive”>Results: </span><input type=”text” name=”results” /><br />
<span class=”labelclass” style=”font-family:’Comic Sans MS’, cursive”>Date: </span><input type=”date” name=”Date” /><br />
<input type=”submit” name=”submit” value=”submit” style=”background-color:#F60″ />
</body>
</html>
[/code]

[HR][/HR]
This is labeled db_tb.php

[code=php]
<!DOCTYPE html PUBLIC “-//W3C//DTD XHTML 1.0 Transitional//EN” “http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd”>
<html xmlns=”http://www.w3.org/1999/xhtml”>
<head>
<meta http-equiv=”Content-Type” content=”text/html; charset=utf-8″ />
<title>Untitled Document</title>
</head>

<body>
<?php
$host = “localhost”; // Host name
$username = “root”; // Mysql username…please try and locate your mysql
//configuration. i.e. your username and password.
$password = “”; // Mysql password
// Connect to server
mysql_connect(“$host”, “$username”, “$password”) or die(‘ERROR: Cannot connect’ .mysql_error());

//here is the newly added code..Selecting the database
mysql_query(“USE mydb”);

$sql = mysql_query( “CREATE TABLE UserNote (CustomerName varchar(255), Phone varchar(255), Email varchar(150), Issue varchar(255), Result varchar(255))”);

if ($sql) {
echo “Database and table created succesffully”;
}
else {
die (‘ERROR: Cannot connect’.mysql_error());
}
?>
</body>
</html>
[/code]

[HR][/HR]
This is labeled insert.php

[code=php]
<!DOCTYPE html PUBLIC “-//W3C//DTD XHTML 1.0 Transitional//EN” “http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd”>
<html xmlns=”http://www.w3.org/1999/xhtml”>
<head>
<meta http-equiv=”Content-Type” content=”text/html; charset=utf-8″ />
<title>Untitled Document</title>
</head>

<center>
<h1><u>Notes For The Month Of August</u></h1>
</center>

<body>
<?php
//Protect against mysql_injection

$customername = mysql_real_escape_string(trim($_POST[“customername”]));
$phonenumber = mysql_real_escape_string(trim($_POST[“pnumber”]));
$email = mysql_real_escape_string(trim($_POST[“eaddy”]));
$issue = mysql_real_escape_string(trim($_POST[“issue”]));
$result = mysql_real_escape_string(trim($_POST[“results”]));
$date = mysql_real_escape_string(trim($_POST[“Date”]));

//Now check form input(Validating the form).
$errmsg_arr = array(); //Array to store validation errors
$check_Error = false; //Validation error flag

if (empty($customername)){
$errmsg_arr[]= ‘.Please Enter Your Name’;
$check_Error = true;
}
if (empty($phonenumber)){
$errmsg_arr[]= ‘.Please Enter Your Phone Number’;
$check_Error = true;
}
if (empty($email)){
$errmsg_arr[]= ‘.Please Enter Your Email’;
$check_Error = true;
}
if (empty($issue)){
$errmsg_arr[]= ‘.Please what is your issue’;
$check_Error = true;
}
if (empty($result)){
$errmsg_arr[]= ‘.Please what is your issue’;
$check_Error = true;
}
if (empty($date)){
$errmsg_arr[]= ‘.Please what is your issue’;
$check_Error = true;
}
//Printing out any error message stored in the array.
if ($check_Error == true){
echo ‘<h1>ERROR: </h1><h3>Please check below for Error Details</h3>’;

if( isset($errmsg_arr) && is_array($errmsg_arr) && count($errmsg_arr) > 0 ) {
echo ‘<ul><font color=”red”>’;
foreach($errmsg_arr as $msg) {
echo ‘<li><b>Error: &nbsp;&nbsp;&nbsp;’.$msg.'</b></li><br />’;
}
echo ‘</font></ul>’;
}
//Please change the a href link to the name of your page.
echo “<p><a href=’http://localhost/site/practice5.html’>Go Back To Register</a></p>”;
}
//After validating successfully
else {
/* Now we will write a query to insert user details into database */
$host = “localhost”; // Host name…change it to your configuration information.
$username = “root”; // Mysql username…change it to your configuration information.
$password = “”; // Mysql password…change it to your configuration information.
$db_name = “mydb”; // Database name…change it to your configuration information.
// Connect to server
mysql_connect(“$host”, “$username”, “$password”) or die(‘ERROR: Cannot connect’ .mysql_error());
//connect to database
mysql_select_db(“$db_name”) or die (‘ERROR: Cannot connect’.mysql_error());

$tbl_name = “UserNote”; //Mysql Table name…change it to your configuration information.

$sql=”INSERT INTO $tbl_name (CustomerName, Phone, Email, Issue, Result, Date)
VALUES($customername’, ‘$phonenumber’, ‘$email’, ‘$issue’, ‘$result’, ‘$date’)”;
}
if ( mysql_query($sql) ) //notice the “!” it means if the mysql_query($sql) cannot be executed, then die error. ELSE execute the mysql_querry($sql) to
//insert into table in the database.
{
die(‘Error in Registration,: ‘ . mysql_error());
}
else
{ //Insert User into the database.
echo ‘Customer Name: ‘. $customername . ‘<br />Phone Number: ‘ .$phonenumber . ‘<br />E-Mail Address: ‘ . $email;
echo ‘<br />Issue:’. $issue . ‘<br />Results:’ . $result . ‘<br />’ . ‘Date:’ .$date . ‘<br />’ ;
}
?>
</body>
</html>
[/code]

[HR][/HR]
This is the error

[QUOTE]

ERROR:
Please check below for Error Details

‘; if( isset($errmsg_arr) && is_array($errmsg_arr) && count($errmsg_arr) > 0 ) { echo ‘
‘; foreach($errmsg_arr as $msg) { echo ‘
Error: ‘.$msg.’

‘; } echo ‘
‘; } //Please change the a href link to the name of your page. echo “
Go Back To Register

“; } //After validating successfully else { /* Now we will write a query to insert user details into database */ $host = “localhost”; // Host name…change it to your configuration information. $username = “root”; // Mysql username…change it to your configuration information. $password = “”; // Mysql password…change it to your configuration information. $db_name = “mydb”; // Database name…change it to your configuration information. // Connect to server mysql_connect(“$host”, “$username”, “$password”) or die(‘ERROR: Cannot connect’ .mysql_error()); //connect to database mysql_select_db(“$db_name”) or die (‘ERROR: Cannot connect’.mysql_error()); $tbl_name = “UserNote”; //Mysql Table name…change it to your configuration information. $sql=”INSERT INTO $tbl_name (CustomerName, Phone, Email, Issue, Result, Date) VALUES($customername’, ‘$phonenumber’, ‘$email’, ‘$issue’, ‘$result’, ‘$date’)”; } if ( mysql_query($sql) ) //notice the “!” it means if the mysql_query($sql) cannot be executed, then die error. ELSE execute the mysql_querry($sql) to //insert into table in the database. { die(‘Error in Registration,: ‘ . mysql_error()); } else { //Insert User into the database. echo ‘Customer Name: ‘. $customername . ‘
Phone Number: ‘ .$phonenumber . ‘
E-Mail Address: ‘ . $email; echo ‘
Issue:’. $issue . ‘
Results:’ . $result . ‘
‘ . ‘Date:’ .$date . ‘
‘ ; } ?>

[/QUOTE]

to post a comment
PHP

4 Comments(s)

Copy linkTweet thisAlerts:
@NogDogAug 16.2013 — Looks like it's not being processed as a PHP file. If running it locally, are you running a web server on your computer, and accessing any page involved via a "http://" link instead of a "file://" link?
Copy linkTweet thisAlerts:
@spudly1987authorAug 16.2013 — Yes currently I am using XAMPP and running it though the local host , the direct link is http://localhost/site/, But even before I do that, its showing that message in Dreamweaver which I am using as well.
Copy linkTweet thisAlerts:
@NogDogAug 16.2013 — Well, if I save the insert.php code as insert.[B]html[/B] and the try to load it in my browser, I get the output you showed here, which tells me it's not being processed as a PHP script. So, make sure that apache is actually running (won't even get this far, though, if you use a "http://localhost" request if Apache is not running), that you really saved it with a ".php" suffix, are accessing it via a "localhost" url, etc.

PS: If you're trying to run it from within Dreamweaver, I have no idea what configuration settings that requires, as I'm not a DW user. ?
Copy linkTweet thisAlerts:
@rootAug 23.2013 — [code=php]<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>

<body>
<?php

$host = "localhost"; // Host name
$username = "root"; // Mysql username...please try and locate your mysql

//configuration. i.e. your username and password.
$password = ""; // Mysql password
// Connect to server
mysql_connect("$host", "$username", "$password") or die('ERROR: Cannot connect' .mysql_error());

//here is the newly added code..Selecting the database
mysql_query("USE mydb");

$sql = mysql_query( "CREATE TABLE UserNote (CustomerName varchar(255), Phone varchar(255), Email varchar(150), Issue varchar(255), Result varchar(255))");

if ($sql) {
echo "Database and table created succesffully";
}
else {
die ('ERROR: Cannot connect'.mysql_error());
}
?>
</body>
</html>[/code]


Why have you got HTML wrapped around a block of PHP code?

Change to this, save it as database.php
[code=php]<?php

$host = "localhost"; // Host name
$username = "root"; // Mysql username...please try and locate your mysql

//configuration. i.e. your username and password.
$password = ""; // Mysql password
// Connect to server
mysql_connect("$host", "$username", "$password") or die('ERROR: Cannot connect' .mysql_error());

//here is the newly added code..Selecting the database
mysql_query("USE mydb");

$sql = mysql_query( "CREATE TABLE UserNote (CustomerName varchar(255), Phone varchar(255), Email varchar(150), Issue varchar(255), Result varchar(255))");

if ($sql) {
echo "Database and table created succesffully";
}
else {
die ('ERROR: Cannot connect'.mysql_error());
}
?>
</html>[/code]


Then in the insert.php file add...
[code=php]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
</head>

<center>
<h1><u>Notes For The Month Of August</u></h1>
</center>

<body>
<?php

// Add this include.
include("database.php");

//Protect against mysql_injection

$customername = mysql_real_escape_string(trim($_POST["customername"]));
$phonenumber = mysql_real_escape_string(trim($_POST["pnumber"]));
$email = mysql_real_escape_string(trim($_POST["eaddy"]));
$issue = mysql_real_escape_string(trim($_POST["issue"]));
$result = mysql_real_escape_string(trim($_POST["results"]));
$date = mysql_real_escape_string(trim($_POST["Date"]));
[/code]

Which is something I suggested before.

From a security stand point, none of your inputs are sanitized and can lead to hack attempts breaking your PHP and or SQL Injection.

I suggest that you sanitize your inputs in to a safe array and also use a white list of what inputs your script accepts. This is a rough idea of how I would tackle the problem.
[code=php]function sanitize( $v ){
// example of striping slashes and HTML tags
return stripslashes(htmlentities($v));
}

$safe_POST = array("customername"=>"","pnumber"=>"","eaddy"=>"","issue"=>"","results"=>"","Date"=>"");

foreach($safe_POST as $key=>$v) $safe_POST[$key] = sanitize( $_POST[$key] );

$errmsg_arr = array('.Please Enter Your Name'=>false,
'.Please Enter Your Phone Number'=>false,
'.Please Enter Your Email'=>false,
'.Please what is your issue'=>false,
'.Please what is your issue'=>false,
'.Please what is your issue'=>false
);
// checking for empty fields
foreach( $safe_POST as $k=>$v)
if( empty($v) ) $errmsg_arr[$key] = true;

if( in_array( true , $errmsg_arr ) ){
echo '<ul><font color="red">';
foreach( $errmsg_arr as $err=>$v) {
if($v) echo "<li><b>Error: &nbsp;&nbsp;&nbsp;{$err}</b></li><br />";
}
echo '</font></ul>';
}else{
// turn contents in to variables
extract( $safe_POST );
}

//... rest of script to fit needs...[/code]
×

Success!

Help @spudly1987 spread the word by sharing this article on Twitter...

Tweet This
Sign in
Forgot password?
Sign in with TwitchSign in with GithubCreate Account
about: ({
version: 0.1.9 BETA 6.17,
whats_new: community page,
up_next: more Davinci•003 tasks,
coming_soon: events calendar,
social: @webDeveloperHQ
});

legal: ({
terms: of use,
privacy: policy
});
changelog: (
version: 0.1.9,
notes: added community page

version: 0.1.8,
notes: added Davinci•003

version: 0.1.7,
notes: upvote answers to bounties

version: 0.1.6,
notes: article editor refresh
)...
recent_tips: (
tipper: @nearjob,
tipped: article
amount: 1000 SATS,

tipper: @meenaratha,
tipped: article
amount: 1000 SATS,

tipper: @meenaratha,
tipped: article
amount: 1000 SATS,
)...