/    Sign up×
Community /Pin to ProfileBookmark

MySQL update is not working

Copy linkTweet thisAlerts:
Oct 23.2012

I’m trying to edit a MySQL row and its not working.
This is the the file that updates the changes

Help anybody?

<?php

include “database-connection.php”;
//get id column
$store_id = $_GET[‘id’];

$store = $_POST[‘storeNumberUpdate’];

$result = mysql_query(“UPDATE Stores SET Store=’$store’ WHERE id=’$store_id'”);

header(“location:edit-delete-store.php”);
?>

to post a comment
PHP

3 Comments(s) ↴

Copy linkTweet thisAlerts:
@ZABIOct 24.2012 — try $result = mysql_query("UPDATE Stores SET Store='$store' WHERE id='$store_id'") or die(mysql_error());

passing the values from GET/POST/REQUEST etc... directly in sql query can increase the risk of SQL Injection, you must perform some kind of validation, or atleast mysql_real_escape_string if values are string or (int)$_GET['id'] if integer.
Copy linkTweet thisAlerts:
@A123SchmidtauthorOct 24.2012 — Yeah, still not editing or working

Here is the edit form

<!DOCTYPE HTML>

<html>

<head>

<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

<title>Untitled Document</title>

<link rel="stylesheet" href="admin-style.css" type="text/css" />

</head>

<body id="edit-delete-store">

<?php

include "header.php"

?>

<div class="top-content-page"></div>

<div class="main-page">

<?php

include "database-connection.php";




$store_id = $_GET['id'];


$result = mysql_query("SELECT * FROM Stores WHERE id = '$store_id'");


$row = mysql_fetch_array($result);




?>

<h2>Edit Store</h2>


<div class="border">

<div class="form">
<form method="post" action="change-store.php">
<input type="hidden" name="id" value="<?php echo $row['id']; ?>" />
<div class="line">
<div class="line-label">
<label for="storeNumberUpdate"><strong>Store Number:</strong></label>
</div>
<input type="text" name="storeNumberUpdate" value="<?php echo $row['Store']; ?>" />
</div>
<div class="line">
<div class="line-label">
<label for="storeEmail"><strong>Email:</strong></label>
</div>
<input type="text" name="storeEmailUpdate" value="<?php echo $row['Email']; ?>" />
</div>
<div class="line">
<div class="line-label">
<label for="storeAddress"><strong>Address:</strong></label>
</div>
<input type="text" name="storeAddressUpdate" value="<?php echo $row['Address']; ?>" />
</div>
<div class="line">
<div class="line-label">
<label for="storePhoneNumber"><strong>Phone Number:</strong></label>
</div>
<input type="text" name="storePhoneNumberUpdate" value="<?php echo $row['Phone']; ?>" />
</div>
<div class="line">
<div class="line-label">
<label for="storeManger"><strong>Manager:</strong></label>
</div>
<input type="text" name="storeManagerUpdate" value="<?php echo $row['Manager']; ?>" />
</div>
<input type="submit" name="Edit" value="Edit" />
</form>

</div>
<?php
mysql_close($con);
?>

</div>
<footer>

<p class="footer-text">Horizon Holding &copy; Copyright. All Rights Reserved.</p>

</footer>


</div>



</body>

</html>
Copy linkTweet thisAlerts:
@A123SchmidtauthorOct 24.2012 — still not working

here is the edit form if this is the issue

help anybody?



<!DOCTYPE HTML>

<html>

<head>

<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

<title>Untitled Document</title>

<link rel="stylesheet" href="admin-style.css" type="text/css" />

</head>

<body id="edit-delete-store stores">

<?php

include "header.php"

?>

<div class="top-content-page"></div>

<div class="main-page">

<?php

include "database-connection.php";




$store_id = $_GET['id'];


$result = mysql_query("SELECT * FROM Stores WHERE id = '$store_id'");


$row = mysql_fetch_array($result);




?>

<h2>Edit Store No: <?php echo $row['Store']; ?></h2>


<div class="border">

<div class="form">
<form method="post" action="change-store.php ">
<input type="hidden" name="id" value="<?php echo $row['id']; ?>" />
<div class="line">
<div class="line-label">
<label for="storeNumberUpdate"><strong>Store Number:</strong></label>
</div>
<input type="text" name="storeNumberUpdate" value="<?php echo $row['Store']; ?>" />
</div>
<div class="line">
<div class="line-label">
<label for="storeEmail"><strong>Email:</strong></label>
</div>
<input type="text" name="storeEmailUpdate" value="<?php echo $row['Email']; ?>" />
</div>
<div class="line">
<div class="line-label">
<label for="storeAddress"><strong>Address:</strong></label>
</div>
<input type="text" name="storeAddressUpdate" value="<?php echo $row['Address']; ?>" />
</div>
<div class="line">
<div class="line-label">
<label for="storePhoneNumber"><strong>Phone Number:</strong></label>
</div>
<input type="text" name="storePhoneNumberUpdate" value="<?php echo $row['Phone']; ?>" />
</div>
<div class="line">
<div class="line-label">
<label for="storeManger"><strong>Manager:</strong></label>
</div>
<input type="text" name="storeManagerUpdate" value="<?php echo $row['Manager']; ?>" />
</div>
<input type="submit" name="Edit" value="Edit" />
</form>

</div>
<?php
mysql_close($con);
?>

</div>
<footer>

<p class="footer-text">Horizon Holding &copy; Copyright. All Rights Reserved.</p>

</footer>


</div>



</body>

</html>
×

Success!

Help @A123Schmidt spread the word by sharing this article on Twitter...

Tweet This
Sign in
Forgot password?
Sign in with TwitchSign in with GithubCreate Account
about: ({
version: 0.1.9 — BETA 5.19,
whats_new: community page,
up_next: more Davinci•003 tasks,
coming_soon: events calendar,
social: @webDeveloperHQ
});

legal: ({
terms: of use,
privacy: policy
});
changelog: (
version: 0.1.9,
notes: added community page

version: 0.1.8,
notes: added Davinci•003

version: 0.1.7,
notes: upvote answers to bounties

version: 0.1.6,
notes: article editor refresh
)...
recent_tips: (
tipper: @AriseFacilitySolutions09,
tipped: article
amount: 1000 SATS,

tipper: @Yussuf4331,
tipped: article
amount: 1000 SATS,

tipper: @darkwebsites540,
tipped: article
amount: 10 SATS,
)...