/    Sign up×
Community /Pin to ProfileBookmark

Please pick apart my CSS

Copy linkTweet thisAlerts:
Aug 10.2012

I am constantly trying to improve my HTML/CSS skills. Please have a look at the following 2 pages (part of the same site) and tell me if there is anything I am doing wrong (or can do better) in regards to the HTML & CSS.

[url]http://kmkwebdesign.ca/clients/creative/index.html[/url]

[url]http://kmkwebdesign.ca/clients/creative/other_sub_page.html[/url] (this page is the 1st link in the “about” drop down menu).

Thanks.

to post a comment
CSS

4 Comments(s) ↴

Copy linkTweet thisAlerts:
@tracknutAug 10.2012 — Overall no big issues for me, so consider these to be very picky comments ?

- I see some inline styling that I would put into your css file

- Your #nav div seems extraneous, I'd have the #nav id on the <ul> if that's all you're putting in #nav

- Extraneous ";" at the end of each CSS style drives me a bit nuts, though I realize some folks teach that you should have one there

- You've used drop shadows on text and boxes, though your doctype doesn't allow it. If it were me, I'd make this an html5/css3 doctype, and use those harmless styles as well as the various new html tags for <nav>, <header>, <footer>, etc.

Dave
Copy linkTweet thisAlerts:
@CaptainkewlauthorAug 10.2012 — Thank you for the input Dave. I made a few adjustments to minimize the "inline" CSS. I tried to only use inline on something that was proprietary to a single page (home page).
Copy linkTweet thisAlerts:
@absolutmgd13Aug 13.2012 — if you compress the stylesheet you cut almost 900 byes off of it, other than that looks good!
Copy linkTweet thisAlerts:
@CaptainkewlauthorAug 13.2012 — Thanks for the input. Never thought of compressing the CSS (thanks).
×

Success!

Help @Captainkewl spread the word by sharing this article on Twitter...

Tweet This
Sign in
Forgot password?
Sign in with TwitchSign in with GithubCreate Account
about: ({
version: 0.1.9 — BETA 5.18,
whats_new: community page,
up_next: more Davinci•003 tasks,
coming_soon: events calendar,
social: @webDeveloperHQ
});

legal: ({
terms: of use,
privacy: policy
});
changelog: (
version: 0.1.9,
notes: added community page

version: 0.1.8,
notes: added Davinci•003

version: 0.1.7,
notes: upvote answers to bounties

version: 0.1.6,
notes: article editor refresh
)...
recent_tips: (
tipper: @AriseFacilitySolutions09,
tipped: article
amount: 1000 SATS,

tipper: @Yussuf4331,
tipped: article
amount: 1000 SATS,

tipper: @darkwebsites540,
tipped: article
amount: 10 SATS,
)...