Menu
Community /Pin to ProfileBookmark
@NogDogMar 31.2011 — #Just a guess, I didn't work it through completely, but I suspect this:
...should maybe be this?
@NogDogMar 31.2011 — #I threw your function into a little test script and it seemed to work just fine, converting a 300x300 image to 200x200.
@NogDogMar 31.2011 — #
Well, when I run the script, I get a 200x200 image, indicating that it resized the original and saved it to the specified file, so as far as I can tell the resize function is working fine.
One thing I'd try is to add a check on the call to getimagesize() and make sure it's not false (maybe the image file is corrupt or otherwise unreadable by that function?) Also, you may want to cast your calculated resize dimensions to integers in case it does not like a width of 200.333, for example.
Otherwise, if you have a copy of the image in question you don't mind us using to test, you could attach it to a post here so I can try it with that.@NogDogMar 31.2011 — #This seems to work. I think the application of (int) to the width/height calculations fixed it.
You might want to get rid of the die() where I tested the getimagesize() result and just log an error and return false, instead. ?@NogDogMar 31.2011 — #Changed the logic/math for determining if should base resizing on the width or the height:
@NogDogApr 01.2011 — #I think it *was* resizing, but not as much as you wanted when the image dimensions were such that the ratio of the original width/height was closer to 1 than the ratio of the new widht/height. So that bit of code I added was adapted from an old script I had, such that it compares the aspect ratio of the original image to that of the desired max dimensions in order to figure out which dimension to use to determine the resizing factor.
Image resize failed?
Ok so I have a function to resize images when I upload, its called twice once for the thumbnail once for a full size. I’ve used my uploading a number of times so far and its always worked perfectly but now I’m having a problem. When I upload a square image, it works for the thumbnail but not the full size. Anyway here’s what I got, maybe I missed something…
[code=php]
function imageResize($src,$target,$newWidth,$newHeight) {
// $src = original file
// $target = new file
// $newWidth / $newHeight represent maximum dimensions
list($origWidth,$origHeight) = getimagesize($src); // Get original dimensions
if( $origWidth > $origHeight ) { // set new width/height to maintain aspect ratio
$newHeight = ($newWidth/$origWidth)*$origHeight;
} else {
$newWidth = ($newHeight/$origHeight)*$origWidth;
}
if( $origHeight < $newHeight && $origWidth < $newWidth) {
$newHeight = $origHeight;
$newWidth = $origWidth;
}
$base = imagecreatefromjpeg($src); // open source
$temp = imagecreatetruecolor($newWidth,$newHeight); //create new file
imagecopyresampled($temp,$base,0,0,0,0,$newWidth,$newHeight,$origWidth,$origHeight); // resample source into new file
if ( imagejpeg($temp,$target) ) { // copy new file to target location, if successful return true otherwise return false.
return TRUE;
} else {
return FALSE;
}
}
// upload script calling it
$tnfile = “{$uploaddir}{$filename}.{$ext}”;
$viewfile = “{$uploaddir}{$filename}_1.{$ext}”;
$error = 0;
if( imageResize($pics,$tnfile,”200″,”133″) ) {
$content .= “Thumbnail successful.<br />”;
} else {
$content .= “Thumbnail failed.<br />”;
$error++;
}
if( imageResize($pics,$viewfile,”640″,”800″) ) {
$content .= “View file successful.<br />”;
} else {
$content .= “View file failed.<br />”;
$error++;
}
Like I said it worked on the thumbnail, so I’m lost i thought maybe because it was square but then why would it still work for the thumbnail? Also there is quite a bit more to upload part, if you feel I should post that too let me know.
As always, thanks in advance! <3
Sign in
to post a comment13 Comments(s) ↴
0
@NogDogMar 31.2011 — #Just a guess, I didn't work it through completely, but I suspect this:[code=php]
if( $origHeight < $newHeight && $origWidth < $newWidth) {
[/code]...should maybe be this?
[code=php]
if( $origHeight <= $newHeight && $origWidth <= $newWidth) {
[/code]0
@NogDogMar 31.2011 — #I threw your function into a little test script and it seemed to work just fine, converting a 300x300 image to 200x200.[code=php]
<?php
ini_set('display_errors', 1);
error_reporting(E_ALL);
$file1 = tempnam('.', 'img_');
$file2 = tempnam('.', 'img_');
// Create a 300x300 image
$im = imagecreate(300, 300);
// Set the background to be blue
imagecolorallocate($im, 0, 0, 200);
// Output the image to file
imagejpeg($im, $file1, 100);
imagedestroy($im);
if(imageResize($file1, $file2, 200, 200)) {
header('Content-Type: image/jpeg');
readfile($file2);
}
else {
user_error("function returned false");
}
unlink($file1);
unlink($file2);
function imageResize($src, $target, $newWidth, $newHeight)
{
// $src = original file
// $target = new file
// $newWidth / $newHeight represent maximum dimensions
list($origWidth, $origHeight) = getimagesize($src); // Get original dimensions
if ($origWidth > $origHeight) { // set new width/height to maintain aspect ratio
$newHeight = ($newWidth / $origWidth) * $origHeight;
} else {
$newWidth = ($newHeight / $origHeight) * $origWidth;
}
if ($origHeight < $newHeight && $origWidth < $newWidth) {
$newHeight = $origHeight;
$newWidth = $origWidth;
}
$base = imagecreatefromjpeg($src); // open source
$temp = imagecreatetruecolor($newWidth, $newHeight); //create new file
imagecopyresampled($temp, $base, 0, 0, 0, 0, $newWidth, $newHeight, $origWidth, $origHeight); // resample source into new file
if (imagejpeg($temp, $target)) { // copy new file to target location, if successful return true otherwise return false.
return TRUE;
} else {
return FALSE;
}
}
[/code]0
@NogDogMar 31.2011 — #Its not returning FALSE, its returning TRUE and not resizing the picture. which means its being added to the database and still larger than my layout.[/QUOTE]
Well, when I run the script, I get a 200x200 image, indicating that it resized the original and saved it to the specified file, so as far as I can tell the resize function is working fine.
One thing I'd try is to add a check on the call to getimagesize() and make sure it's not false (maybe the image file is corrupt or otherwise unreadable by that function?) Also, you may want to cast your calculated resize dimensions to integers in case it does not like a width of 200.333, for example.
Otherwise, if you have a copy of the image in question you don't mind us using to test, you could attach it to a post here so I can try it with that.
0
@NogDogMar 31.2011 — #This seems to work. I think the application of (int) to the width/height calculations fixed it.[code=php]
function imageResize($src, $target, $newWidth, $newHeight)
{
// $src = original file
// $target = new file
// $newWidth / $newHeight represent maximum dimensions
$sizeInfo = getimagesize($src); // Get original dimensions
if($sizeInfo == false) { die("getimagesize failed");}
list($origWidth, $origHeight) = $sizeInfo;
if ($origWidth > $origHeight) { // set new width/height to maintain aspect ratio
$newHeight = (int)(($newWidth / $origWidth) * $origHeight);
} else {
$newWidth = (int)(($newHeight / $origHeight) * $origWidth);
}
if ($origHeight < $newHeight && $origWidth < $newWidth) {
$newHeight = $origHeight;
$newWidth = $origWidth;
}
$base = imagecreatefromjpeg($src); // open source
$temp = imagecreatetruecolor($newWidth, $newHeight); //create new file
imagecopyresampled($temp, $base, 0, 0, 0, 0, $newWidth, $newHeight, $origWidth, $origHeight); // resample source into new file
if (imagejpeg($temp, $target)) { // copy new file to target location, if successful return true otherwise return false.
return TRUE;
} else {
return FALSE;
}
}
[/code]You might want to get rid of the die() where I tested the getimagesize() result and just log an error and return false, instead. ?
0
@NogDogMar 31.2011 — #Changed the logic/math for determining if should base resizing on the width or the height:[code=php]
function imageResize($src, $target, $newWidth, $newHeight)
{
// $src = original file
// $target = new file
// $newWidth / $newHeight represent maximum dimensions
$sizeInfo = getimagesize($src); // Get original dimensions
if($sizeInfo == false) { die("getimagesize faile");}
list($origWidth, $origHeight) = $sizeInfo;
// new stuff:
$ratio = (($origWidth / $origHeight) > ($newWidth / $newHeight)) ?
$newWidth / $origWidth : $newHeight / $origHeight;
$newWidth = (int) ($origWidth * $ratio);
$newHeight = (int) ($origHeight * $ratio);
// end new stuff
if ($origHeight < $newHeight && $origWidth < $newWidth) {
$newHeight = $origHeight;
$newWidth = $origWidth;
}
$base = imagecreatefromjpeg($src); // open source
$temp = imagecreatetruecolor($newWidth, $newHeight); //create new file
imagecopyresampled($temp, $base, 0, 0, 0, 0, $newWidth, $newHeight, $origWidth, $origHeight); // resample source into new file
if (imagejpeg($temp, $target)) { // copy new file to target location, if successful return true otherwise return false.
return TRUE;
} else {
return FALSE;
}
}[/code]0
@NogDogApr 01.2011 — #I think it *was* resizing, but not as much as you wanted when the image dimensions were such that the ratio of the original width/height was closer to 1 than the ratio of the new widht/height. So that bit of code I added was adapted from an old script I had, such that it compares the aspect ratio of the original image to that of the desired max dimensions in order to figure out which dimension to use to determine the resizing factor.