/    Sign up×
Community /Pin to ProfileBookmark

[RESOLVED] clean and shorten combobox load code

below I have an array and I also have a script set up to load the array into my combo boxes. the code below is very ugly and I know there is a way to clean it up and shorten what I am doing. I was wondering if anyone can help me clean and shorten this working code

[CODE]var dayArray = [‘monday’, ‘tuesday’, ‘wednesday’, ‘thursday’, ‘friday’, ‘saturday’, ‘sunday’];
var hoursArray = [
“No Office Hours”,
“00:00”, “00:15”, “00:30”, “00:45”,
“01:00”, “01:15”, “01:30”, “01:45”,
“02:00”, “02:15”, “02:30”, “02:45”,
“03:00”, “03:15”, “03:30”, “03:45”,
“04:00”, “04:15”, “04:30”, “04:45”,
“05:00”, “05:15”, “05:30”, “05:45”,
“06:00”, “06:15”, “06:30”, “06:45”,
“07:00”, “07:15”, “07:30”, “07:45”,
“08:00”, “08:15”, “08:30”, “08:45”,
“09:00”, “09:15”, “09:30”, “09:45”,
“10:00”, “10:15”, “10:30”, “10:45”,
“11:00”, “11:15”, “11:30”, “11:45”,
“12:00”, “12:15”, “12:30”, “12:45”,
“13:00”, “13:15”, “13:30”, “13:45”,
“14:00”, “14:15”, “14:30”, “14:45”,
“15:00”, “15:15”, “15:30”, “15:45”,
“16:00”, “16:15”, “16:30”, “16:45”,
“17:00”, “17:15”, “17:30”, “17:45”,
“18:00”, “18:15”, “18:30”, “18:45”,
“19:00”, “19:15”, “19:30”, “19:45”,
“20:00”, “20:15”, “20:30”, “20:45”,
“21:00”, “21:15”, “21:30”, “21:45”,
“22:00”, “22:15”, “22:30”, “22:45”,
“23:00”, “23:15”, “23:30”, “23:45”,
“24:00”
];
var startDayMon = document.getElementsByName(“timeofday_start_” + dayArray[0])[0];
var endDayMon = document.getElementsByName(“timeofday_end_” + dayArray[0])[0];
var startDayTue = document.getElementsByName(“timeofday_start_” + dayArray[1])[0];
var endDayTue = document.getElementsByName(“timeofday_end_” + dayArray[1])[0];
var startDayWed = document.getElementsByName(“timeofday_start_” + dayArray[2])[0];
var endDayWed = document.getElementsByName(“timeofday_end_” + dayArray[2])[0];
var startDayThu = document.getElementsByName(“timeofday_start_” + dayArray[3])[0];
var endDayThu = document.getElementsByName(“timeofday_end_” + dayArray[3])[0];
var startDayFri = document.getElementsByName(“timeofday_start_” + dayArray[4])[0];
var endDayFri = document.getElementsByName(“timeofday_end_” + dayArray[4])[0];
var startDaySat = document.getElementsByName(“timeofday_start_” + dayArray[5])[0];
var endDaySat = document.getElementsByName(“timeofday_end_” + dayArray[5])[0];
var startDaySun = document.getElementsByName(“timeofday_start_” + dayArray[6])[0];
var endDaySun = document.getElementsByName(“timeofday_end_” + dayArray[6])[0];

for (a = 0; a < hoursArray.length; a++) {

startDayMon.options[a] = new Option(hoursArray[a], hoursArray[a]);
endDayMon.options[a] = new Option(hoursArray[a], hoursArray[a]);
startDayTue.options[a] = new Option(hoursArray[a], hoursArray[a]);
endDayTue.options[a] = new Option(hoursArray[a], hoursArray[a]);
startDayWed.options[a] = new Option(hoursArray[a], hoursArray[a]);
endDayWed.options[a] = new Option(hoursArray[a], hoursArray[a]);
startDayThu.options[a] = new Option(hoursArray[a], hoursArray[a]);
endDayThu.options[a] = new Option(hoursArray[a], hoursArray[a]);
startDayFri.options[a] = new Option(hoursArray[a], hoursArray[a]);
endDayFri.options[a] = new Option(hoursArray[a], hoursArray[a]);
startDaySat.options[a] = new Option(hoursArray[a], hoursArray[a]);
endDaySat.options[a] = new Option(hoursArray[a], hoursArray[a]);
startDaySun.options[a] = new Option(hoursArray[a], hoursArray[a]);
endDaySun.options[a] = new Option(hoursArray[a], hoursArray[a]);
}[/CODE]

to post a comment
JavaScript

1 Comments(s)

Copy linkTweet thisAlerts:
@mthorauthorOct 08.2010 — well it seems that I answer more of my own questions then getting help, oh well . I figured it out and here is the code if someone else needs to get load a combobox with a value from an array list and have a value be selected.

[CODE]for (d = 0; d < dayArray.length; d++){
var startDay = document.getElementsByName("timeofday_start_" + dayArray[d])[0];
var endDay = document.getElementsByName("timeofday_end_" + dayArray[d])[0];
var startDayValue = startDay.value;
var endDayValue = endDay.value;
for (i = 0; i < hoursArray.length; i++) {
startDay.options[i] = new Option(hoursArray[i], hoursArray[i]); // after I loop to sunday I get options is undefined
if (startDayValue === hoursArray[i]) {
startDay.options[i].selected = true;
}
endDay.options[i] = new Option(hoursArray[i], hoursArray[i]); // after I loop to sunday I get options is undefined
if (endDayValue === hoursArray[i]) {
endDay.options[i].selected = true;
}
}}[/CODE]
×

Success!

Help @mthor spread the word by sharing this article on Twitter...

Tweet This
Sign in
Forgot password?
Sign in with TwitchSign in with GithubCreate Account
about: ({
version: 0.1.9 BETA 5.8,
whats_new: community page,
up_next: more Davinci•003 tasks,
coming_soon: events calendar,
social: @webDeveloperHQ
});

legal: ({
terms: of use,
privacy: policy
});
changelog: (
version: 0.1.9,
notes: added community page

version: 0.1.8,
notes: added Davinci•003

version: 0.1.7,
notes: upvote answers to bounties

version: 0.1.6,
notes: article editor refresh
)...
recent_tips: (
tipper: @AriseFacilitySolutions09,
tipped: article
amount: 1000 SATS,

tipper: @Yussuf4331,
tipped: article
amount: 1000 SATS,

tipper: @darkwebsites540,
tipped: article
amount: 10 SATS,
)...