/    Sign up×
Community /Pin to ProfileBookmark

Problem with variable

Copy linkTweet thisAlerts:
Jun 11.2010

Hi!

function BytBild2(number) {
[COLOR=”Red”]test[/COLOR] = “bild” + number.toString();

document.getElementById(“storbild”).src=”bilder/bilder_stora/” + [COLOR=”Red”]test[/COLOR] + “.jpg”;

This dosen’t work! But if I write bild2, then it works! How come it dosen’t work and what do I do wrong? What I’m trying to do is to concatenating different parts to a variable. bild2 ha a value from the beginning. And I just wanted to save a lot of code to put bild + number and use just one line of code instead of several?!

Appreciate som help! Thanks!

to post a comment
JavaScript

9 Comments(s) ↴

Copy linkTweet thisAlerts:
@Declan1991Jun 11.2010 — How do you call it?

And there is no need to call toString. This will do.function BytBild2(number) {
test = "bild" + number;
document.getElementById("storbild").src="bilder/bilder_stora/" + test + ".jpg";
}
BytBild2(2);
Copy linkTweet thisAlerts:
@pkngauthorJun 11.2010 — Thanks! But are you sure it works? I have tried this several times! I'm unsure if it's possible to create a new variable named 'test' by concatenating bild + 1 which already is a variable name, 'bild1', with a value of 0011_1. I can't get this value to the new variable 'test'!?

I call it like BytBild2(2); but as I wrote variables 'bild1' to 'bild5' are already declared variables with different values before I call BytBild2(2);

My thought was to just use less amount of lines of code and create a new variable instead of

if (number == 1) {

document.getElementById("storbild").src="bilder/bilder_stora/" [COLOR="Red"]+bild1+[/COLOR] ".jpg";} bild1 could have the value of 0004_2

......

if (number == 5) {

document.getElementById("storbild").src="bilder/bilder_stora/" [COLOR="Red"]+bild5+[/COLOR] ".jpg";} bild5 could have the value of 0015_5


What I wanted was just this few lines:

function BytBild2(3) {

test = ???? + number

document.getElementById("storbild").src="bilder/bilder_stora/" + [COLOR="Red"]test[/COLOR] + ".jpg";

}

Do you understand how I mean?
Copy linkTweet thisAlerts:
@Vince616Jun 11.2010 — Hi bud

I think your problem is that you forgot to declare your "test" variable
[CODE]
 test = "bild"+ number
[/CODE]
should be
[CODE]
 var test = "bild"+ number
[/CODE]
That said, if it were me I wouldnt bother with the "test" variable
[CODE]
 function ByBild2(number){
document.getElementById("storbild").src="bilder/bilder_stora/bild" + number + ".jpg";
}
[/CODE]

V
Copy linkTweet thisAlerts:
@pkngauthorJun 12.2010 — Hi!

It's not necessary to declare a variable in java script. And if you declare the variable inside a function it gets local scope and will not be global!

I'm trying to create a string, I'm trying to create a new variable and assign a value to it, but guess it's impossible!?
Copy linkTweet thisAlerts:
@FangJun 12.2010 — var test = window["bild" + number];
Copy linkTweet thisAlerts:
@pkngauthorJun 12.2010 — Sorry, but it doesn't work!

var number = 2;

var test = window["bild_" + number];

if I also add an Alert I get a message saying 'undefined' and after some time. Seems like browser locks!?

?
Copy linkTweet thisAlerts:
@Declan1991Jun 12.2010 — I know for absolute sure, guaranteed, that this will do what I say it does.function function BytBild2(number) {
alert("bilder/bilder_stora/bild" + number + ".jpg");
}
BytBild2(2);That code will alert "bilder/bilder_stora/bild2.jpg". If not, you have problems elsewhere in your code. Guaranteed.
Copy linkTweet thisAlerts:
@FangJun 12.2010 — which already is a variable name, 'bild1', with a value of 0011_1. I can't get this value to the new variable 'test'!?[/QUOTE]
Like this?function BytBild2(number) {
var test = window["bild" + number];
document.getElementById("storbild").src="bilder/bilder_stora/" + test + ".jpg";
}
var bild1 = '0011_1';
BytBild2(1);
Copy linkTweet thisAlerts:
@SparoHawkJun 12.2010 — Guys, what he wants is to create a variable name from string to read its value. Something by the like of the following in PHP:

[CODE]<?php
$blid1 ='test';
$num = 1;
$test = ${'blid'.$num};

echo $test;
?>[/CODE]

Edit:

[B]Fang[/B]'s proposal is a nice work around. Try that.
×

Success!

Help @pkng spread the word by sharing this article on Twitter...

Tweet This
Sign in
Forgot password?
Sign in with TwitchSign in with GithubCreate Account
about: ({
version: 0.1.9 — BETA 5.19,
whats_new: community page,
up_next: more Davinci•003 tasks,
coming_soon: events calendar,
social: @webDeveloperHQ
});

legal: ({
terms: of use,
privacy: policy
});
changelog: (
version: 0.1.9,
notes: added community page

version: 0.1.8,
notes: added Davinci•003

version: 0.1.7,
notes: upvote answers to bounties

version: 0.1.6,
notes: article editor refresh
)...
recent_tips: (
tipper: @AriseFacilitySolutions09,
tipped: article
amount: 1000 SATS,

tipper: @Yussuf4331,
tipped: article
amount: 1000 SATS,

tipper: @darkwebsites540,
tipped: article
amount: 10 SATS,
)...