Menu
Community /Pin to ProfileBookmark
@NogDogOct 29.2009 — #In most cases I would probably set a class variable with the error information and have the method return false. If you foresee a need for the client code using a switch(), you might have two class variables: error number and error text.
@NogDogOct 30.2009 — #
Yes, I would have the function return false, then leave it to the client code to decide if it cares about what the specific error was and get the info from the error variable.
Returning error messages from classes
Hi,
I’m writing a set of classes and am trying to find the best way in general to handle errors which may be encountered within these classes.
For instance, i have a class which handles most things to do with a user. One of the class’s methods is editUser which, when called by client code, first evaluates which of the user’s details have been changed. If the email has been changed another method within the same class is called to check that the email does not already exist.
Now, if the email address already exists then i want a suitable error message to be returned to the client code. If no details have been changed then i want another message returned to the client code. If the method completes successfully then i want it to return TRUE (or similar) to the client code. And if it fails for any other reason then i want to return FALSE (or similar).
What is the best regarded solution to doing things like this? One thing i thought of doing was returning codes from each part of the method like:
101 = email exists
102 = no changes made
103 = operation successful
104 = operation failed
..and then the client code can use a switch statement on the object and perform the relevant action.
What works best?
Sign in
to post a comment5 Comments(s) ↴
0
@NogDogOct 29.2009 — #In most cases I would probably set a class variable with the error information and have the method return false. If you foresee a need for the client code using a switch(), you might have two class variables: error number and error text.[code=php]
class Foo
{
public $errNo; // last error number
public $errMsg; // last error message
public function bar($x)
{
if($x == 0)
{
$this->errNo = 1;
$this->errMsg = "X is 0";
return false;
}
return true;
}
}
[/code]0
@NogDogOct 30.2009 — #Hiya NogDog,
Going with your first suggestion - setting a class variable and returning false - presumably the client would then test for true/false and if false get the error message? like...
[code=php]echo ($fooh->bar($x))?"Success!":$fooh->getErrMsg();[/code]
The idea for using a switch was just because i hadn't thought the above, but i can see the above much more logical/useful.[/QUOTE]
Yes, I would have the function return false, then leave it to the client code to decide if it cares about what the specific error was and get the info from the error variable.