/    Sign up×
Community /Pin to ProfileBookmark

onclick statement doesn’t work

Hi all, I am trying to set an onclick statement. I have done this before but this time it seems to go wrong.

The browser doesn’t see any mistakes and neither does my MacroMedia. I have been checking the code to see what’s wrong but I really can’t find it.

The webpage looks like this

[CODE]
<html>
<head>
<title>Post message in chat</title>
<meta http-equiv=”Content-Type” content=”text/html; charset=iso-8859-1″>

<style type=”text/css”>
img, a {border: 0;}
.smilyButton { cursor: pointer; }
</style>

<script type=”text/javascript”>
<!–//
// Run function onload
onload = initSmilies;

// Set all listeners
function initSmilies() {
if(document.getElementById(“smilySmile”)) { // Check if there are smilies
document.getElementById(“smilySmile”).onclick = messageAdd(“:)”); // Run function when smily is clicked
document.getElementById(“smilySad”).onclick = messageAdd(“:(“); // Run function when smily is clicked
document.getElementById(“smilyAngry”).onclick = messageAdd(“:@”); // Run function when smily is clicked
document.getElementById(“smilyWink”).onclick = messageAdd(“;)”); // Run function when smily is clicked
document.getElementById(“smilyCool”).onclick = messageAdd(“:h”); // Run function when smily is clicked
document.getElementById(“smilyTongue”).onclick = messageAdd(“:p”); // Run function when smily is clicked
document.getElementById(“smilyHappy”).onclick = messageAdd(“:d”); // Run function when smily is clicked
document.getElementById(“smilyConfused”).onclick = messageAdd(“:s”); // Run function when smily is clicked
document.getElementById(“smilyCry”).onclick = messageAdd(“:'(“); // Run function when smily is clicked
document.getElementById(“smilyScared”).onclick = messageAdd(“:t”); // Run function when smily is clicked
document.getElementById(“smilyShy”).onclick = messageAdd(“:0”); // Run function when smily is clicked
document.getElementById(“smilyUh”).onclick = messageAdd(“:?”); // Run function when smily is clicked
document.getElementById(“smilyGrin”).onclick = messageAdd(“:v”); // Run function when smily is clicked
document.getElementById(“smilyLol”).onclick = messageAdd(“:u”); // Run function when smily is clicked
document.getElementById(“smilyBiglol”).onclick = messageAdd(“:lol”); // Run function when smily is clicked
document.getElementById(“smilyYeah”).onclick = messageAdd(“:\”); // Run function when smily is clicked
document.getElementById(“smilyWee”).onclick = messageAdd(“:wtf”); // Run function when smily is clicked
document.getElementById(“smilyRight”).onclick = messageAdd(“:|”); // Run function when smily is clicked
document.getElementById(“smilySleep”).onclick = messageAdd(“:z”); // Run function when smily is clicked
}
}

// Function to add smily
function messageAdd(text) {
var messageBox = document.getElementById(“message”); // Get message box
messageBox.value += text; // Add text
messageBox.focus(); // Set focus to message field
}
//–>
</script>
</head>

<body onload=”javascript: messageAdd(”);”>
<div style=”text-align: center;”>
<form action=”chat.post.php?doit=addpost&amp;user=<?php echo $_GET[“user”]; ?>” method=”post” id=”chat” name=”chat”>
<fieldset>
<legend>
<span class=”main”>
<b><font color=”#808080″>&nbsp;Smilies&nbsp;</font></b>
</span>
</legend>
<span class=”main”>
<img src=”images/smilies/smile.BMP” alt=”:)” id=”smilySmile” class=”smilyButton”>
<img src=”images/smilies/sad.BMP” alt=”:(” id=”smilySad” class=”smilyButton”>
<img src=”images/smilies/angry.BMP” alt=”:@” id=”smilyAngry” class=”smilyButton”>
<img src=”images/smilies/wink.BMP” alt=”;)” id=”smilyWink” class=”smilyButton”>
<img src=”images/smilies/cool.BMP” alt=”:h” id=”smilyCool” class=”smilyButton”>
<img src=”images/smilies/tongue.BMP” alt=”:p” id=”smilyTongue” class=”smilyButton”>
<img src=”images/smilies/happy.BMP” alt=”:d” id=”smilyHappy” class=”smilyButton”>
<img src=”images/smilies/confused.BMP” alt=”:s” id=”smilyConfused” class=”smilyButton”>
<img src=”images/smilies/cry.BMP” alt=”:'(” id=”smilyCry” class=”smilyButton”>
<img src=”images/smilies/scared.BMP” alt=”:t” id=”smilyScared” class=”smilyButton”>
<img src=”images/smilies/shy.BMP” alt=”:0″ id=”smilyShy” class=”smilyButton”>
<img src=”images/smilies/uh.BMP” alt=”:?” id=”smilyUh” class=”smilyButton”>
<img src=”images/smilies/grin.BMP” alt=”:v” id=”smilyGrin” class=”smilyButton”>
<img src=”images/smilies/lol.BMP” alt=”:u” id=”smilyLol” class=”smilyButton”>
<img src=”images/smilies/biglol.BMP” alt=”:lol” id=”smilyBiglol” class=”smilyButton”>
<img src=”images/smilies/yeah.BMP” alt=”:\” id=”smilyYeah” class=”smilyButton”>
<img src=”images/smilies/wee.BMP” alt=”:wtf” id=”smilyWee” class=”smilyButton”>
<img src=”images/smilies/right.BMP” alt=”:|” id=”smilyRight” class=”smilyButton”>
<img src=”images/smilies/sleep.BMP” alt=”:z” id=”smilySleep” class=”smilyButton”>
</span>
</fieldset>
<div class=”wrapper”>
<input name=”name” type=”hidden” value=”<% =sessionname %>”>
<input type=”text” name=”message” id=”message” style=”width: 650px”>
<input name=”submit” type=”submit” class=”input” value=”Say” style=”width: 90px”>
</div>
</form>
</div>
</body>
</html>[/CODE]

Normally my js script should be working but this time when I press a smily, nothing happens :s.

Please tell me what’s wrong with it =(

to post a comment
JavaScript

4 Comments(s)

Copy linkTweet thisAlerts:
@FangOct 17.2008 — document.getElementById("smilySmile").onclick = function(){messageAdd(":)");};
Copy linkTweet thisAlerts:
@KingIsulgardauthorOct 17.2008 — Still doesn't work ?
Copy linkTweet thisAlerts:
@FangOct 17.2008 — Remove the onload in the body tag
Copy linkTweet thisAlerts:
@KingIsulgardauthorOct 17.2008 — That solved my problem. Thanks fang :p. Stupid mistake.

Man I could shoot muself right now :p
×

Success!

Help @KingIsulgard spread the word by sharing this article on Twitter...

Tweet This
Sign in
Forgot password?
Sign in with TwitchSign in with GithubCreate Account
about: ({
version: 0.1.9 BETA 6.1,
whats_new: community page,
up_next: more Davinci•003 tasks,
coming_soon: events calendar,
social: @webDeveloperHQ
});

legal: ({
terms: of use,
privacy: policy
});
changelog: (
version: 0.1.9,
notes: added community page

version: 0.1.8,
notes: added Davinci•003

version: 0.1.7,
notes: upvote answers to bounties

version: 0.1.6,
notes: article editor refresh
)...
recent_tips: (
tipper: @meenaratha,
tipped: article
amount: 1000 SATS,

tipper: @meenaratha,
tipped: article
amount: 1000 SATS,

tipper: @AriseFacilitySolutions09,
tipped: article
amount: 1000 SATS,
)...