/    Sign up×
Community /Pin to ProfileBookmark

[RESOLVED] Problem with parameters, please help!

So I have a basic javascript function that uses innerHTML to write buttons to the page to run another function – but I can’t seem to get the parameters to pass correctly – the result is a button that doesn’t do anything! I’m sure it’s my syntax, here’s a dumbed-down version:

function function1(var1,var2,var3,var4,var5) {
var buttons = ‘<a href=’#’ onclick=’javascript:function2(‘+var1+’,’+var2+’,’+var3+’,’+var4+’,’+var5+’);’>CLICK HERE</a>’
document.getElementById(‘buttons’).innerHTML = buttons;
alert(‘var1=’+var1);
}
function function2(var1,var2,var3,var4,var5) {
var buttons = ‘<a href=’#’ onclick=’javascript:function1(‘+var1+’,’+var2+’,’+var3+’,’+var4+’,’+var5+’);’>CLICK HERE</a>’
document.getElementById(‘buttons’).innerHTML = buttons;
alert(‘var1=’+var1);
}

What am I doing wrong? Please help!

to post a comment
JavaScript

1 Comments(s)

Copy linkTweet thisAlerts:
@robmarstonauthorJul 14.2008 — I've found the solution, it seems I was neglecting some single quotes when I was re-writing the button to the page.

The working result is:

function function1(var1,var2,var3,var4,var5) {

var buttons = '<a href="#" onclick="javascript:function2(''+var1+'',''+var2+'',''+var3+'',''+var4+'',''+var5+'');">CLICK HERE</a>'

document.getElementById('buttons').innerHTML = buttons;

}

function function2(var1,var2,var3,var4,var5) {

var buttons = '<a href="#" onclick="javascript:function1(''+var1+'',''+var2+'',''+var3+'',''+var4+'',''+var5+'');">CLICK HERE</a>'

document.getElementById('buttons').innerHTML = buttons;

}

}

Thanks for anyone who had taken a look ?
×

Success!

Help @robmarston spread the word by sharing this article on Twitter...

Tweet This
Sign in
Forgot password?
Sign in with TwitchSign in with GithubCreate Account
about: ({
version: 0.1.9 BETA 5.28,
whats_new: community page,
up_next: more Davinci•003 tasks,
coming_soon: events calendar,
social: @webDeveloperHQ
});

legal: ({
terms: of use,
privacy: policy
});
changelog: (
version: 0.1.9,
notes: added community page

version: 0.1.8,
notes: added Davinci•003

version: 0.1.7,
notes: upvote answers to bounties

version: 0.1.6,
notes: article editor refresh
)...
recent_tips: (
tipper: @AriseFacilitySolutions09,
tipped: article
amount: 1000 SATS,

tipper: @Yussuf4331,
tipped: article
amount: 1000 SATS,

tipper: @darkwebsites540,
tipped: article
amount: 10 SATS,
)...