Menu
Hi,
Since IE doesn’t support Array.shift() and Array.unshift(), I have to override them… but here is the problem, it works in firefox but NOT IE!
here is the code:
[CODE]
// Array.shift override
Array.prototype.shift = function() {
// Get the first value of array through ‘this’
var value = this[0];
for (var ndx = 1; ndx < this.length; ndx++) {
this[ndx – 1] = this[ndx];
}
// Return first value
return value;
};
// Array.unshift override
Array.prototype.unshift = function() {
// Get number of arguments
var nArgs = arguments.length;
var nElements = this.length;
for (var ndx = nElements – 1; ndx >= 0; ndx–) { this[ndx + nArgs] = this[ndx]; }
for (var ndx = 0; ndx < nArgs; ndx++) { this[ndx] = arguments[ndx]; }
// Return the new size of the array
return nElements += nArgs;
};
For some reason, this code doesn’t work under IE. IE says that the object doesn’t support the method.
Any help is appreciated.
Crud
I don't get that error, but your (unnecessary) implementation of [I]shift[/I] is flawed because it doesn't contract the array.
[CODE]
// Array.shift override
Array.prototype.shift = function() {
// Get the first value of array through 'this'
var value = this[0];
for (var ndx = 1; ndx < this.length; ndx++) {
this[ndx - 1] = this[ndx];
}
// Return first value
return value;
};
[/CODE]
For some reason, this code doesn't work under IE. IE says that the object doesn't support the method.
[/QUOTE]
[CODE]this.length-=1;[/CODE]I don't get that error, but your (unnecessary) implementation of [I]shift[/I] is flawed because it doesn't contract the array.
[CODE]this.length-=1;[/CODE][/QUOTE]
Can you show a code example that doesn't work?
everytime I access an array's shift and unshift methods in all versions of IE I get "Object doesn't support this property or method" even WITHOUT trying to override. That is why I'm trying to override the functions, as they don't work in IE. Also, I forgot to mention, this happens in Opera too.
[/QUOTE]
[CODE]<script type='text/javascript'>
var testArray=[73,81,89,54,38,02,81,6];
testArray.shift();
alert(testArray);
testArray.unshift(73);
alert(testArray);
</script>[/CODE]I've found that the shift(); and unshift(); functs work in IE - now scratching head...[CODE]
// Global Code out here by it's lonesome...
// System Object
var system = {
// init function
init: function() {
// Check & Set for one copy only - this is so init() always keeps the same state
if (arguments.callee._singletonInstance) { return arguments.callee._singletonInstance; }
arguments.callee._singletonInstance = this;
},
// browser detection and steering
browser: {
// store browser tests
ie: !!(window.attachEvent && !window.opera),
ie7: !!(window.attachEvent && !window.opera) && navigator.userAgent.indexOf('MSIE 7') > -1,
gecko: {
firefox: navigator.userAgent.indexOf('Gecko') > -1 && navigator.userAgent.indexOf('KHTML') == -1 && navigator.userAgent.indexOf('Firefox') > -1,
ns6plus: navigator.userAgent.indexOf('Gecko') > -1 && navigator.userAgent.indexOf('KHTML') == -1 && navigator.userAgent.indexOf('Netscape') > -1,
generic: navigator.userAgent.indexOf('Gecko') > -1 && navigator.userAgent.indexOf('KHTML') == -1
},
opera: !!window.opera,
opera9: !!window.opera && navigator.userAgent.indexOf('Opera/9') > -1,
opera8: !!window.opera && navigator.userAgent.indexOf('Opera/8') > -1,
opera7: !!window.opera && navigator.userAgent.indexOf('Opera/7') > -1
},
// system queue (functions are queued and executed in a FIFO queue)
queue: {
// Processing flag (check it to see if queue is busy processing)
processing: false,
// Number of queue entries
entries: 0,
// The actual queue (FIFO style push/shift array)
queue: undefined,
// queueObject - an entry in the queue - contains queued functions and their arguments.
queueObject: function(funct, fowner, fargs) {
this.run = funct;
this.args = [];
this.owner = fowner;
if (typeof(fargs) == 'array' || typeof(fargs) == 'object' && fargs) {
this.args = fargs.slice(0);
} else if (fargs == null) {
this.args = [];
} else {
alert('You must pass an array representing function arguments to queueObject().');
return false;
}
},
// Add an entry to the queue
// Extra arguments other than the ones seen are considered function arguments and are put on the queue
// priority is ignored when process() is called with arguments
add: function(funct, fowner, fnice) {
// If queue array is NULL, initialize it
if (!this.queue) { this.queue = new Array(); }
// Check owner (queue entry owner - really just a name)
if (!fowner || fowner == null) { fowner = 'nobody'; }
// Check fnice (priority)
if (!fnice || fnice == null) { fnice = false; }
// Check the type of funct. If function, then put it in the queue.
if (typeof(funct) == 'function') {
// If the function has arguments, insert them
if (arguments.length > 3) {
// cast arguments into an array, and shift() off function call (1st. argument),
// owner (2nd. argument), and priority (3rd.)
var tmp_args = new Array();
tmp_args = Array.slice(arguments);
tmp_args.shift();
tmp_args.shift();
tmp_args.shift();
// Add function & args to queue
// if priority set then stick function & args to front of queue
if (!fnice) {
this.queue.push(new this.queueObject(funct, fowner, tmp_args));
} else {
this.queue.unshift(new this.queueObject(funct, fowner, tmp_args));
}
} else {
// Add function to queue
// if priority set then stick function to front of queue
if (!fnice) {
this.queue.push(new this.queueObject(funct, fowner, undefined));
} else {
this.queue.unshift(new this.queueObject(funct, fowner, undefined));
}
}
// increment queue entries counter
this.entries++;
} else {
// funct wasn't a function, warn user and return false.
alert('You must pass a function to system.queue.add().');
return false;
}
},
// Process the queue
// pass owner(s) to process just those scripts: process('owner', [owner2], ...);
// call bare to process whole queue: process();
process: function() {
// Recurse flag
if (!recurse) { var recurse = false; }
// Check to see if currently processing, if not, set processing flag to true (currently processing queue)
// If processing, see if queue is empty. If not, then process() was called recursively. Allow through.
// If queue is empty, reset processing flag and return true.
if (!this.processing && this.entries && !recurse) {
this.processing = true;
} else if (this.processing && !this.entries) {
recurse = false;
this.processing = false;
return true;
}
// Check if arguments where passed, if so then this is a request to
// process all the scripts owned by owner(s)
if (arguments.length) {
var tmp_args = Array.slice(arguments);
for (var ndx = 0; ndx < tmp_args.length; ndx++) {
for (var ndx2 = 0; ndx2 < this.queue.length; ndx2++) {
if (this.queue[ndx2].owner == tmp_args[ndx]) {
// Process queue...
// run directly from queue, then splice out
this.queue[ndx2].run.apply(this, this.queue[ndx2].args);
this.queue.splice(ndx2, 1);
// Decrement queue entries counter
this.entries--;
ndx--;
}
}
}
recurse = false;
this.processing = false;
return true;
}
// Process queue...
// shift off a function from queue, capture function in a local variable
var funct = this.queue.shift();
// Call function
funct.run.apply(this, funct.args);
// Discard function
delete funct;
// Decrement queue entries counter
this.entries--;
// Set recurse flag and recall process() recursively
recurse = true;
this.process();
}
},
// DOM manipulation
dom: {
// define doctypeObject for storing info about the DOCTYPE
doctypeObject: function() {
// Check & Set for one copy only - this is so this function always keeps the same state
if (arguments.callee._singletonInstance) { return arguments.callee._singletonInstance; }
arguments.callee._singletonInstance = this;
// Make cleaners
this.public_cleaner = /s+(X?HTML){1}s+([d.]+)s*([^/]+)/{2}([A-Za-z]{2})/gi;
// Public string
this.public = document.doctype.publicId;
// markup type - dealing with HTML or XHTML, version, etc...
this.public_cleaner.exec(document.doctype.publicId);
this.markup = {
id: RegExp.$1,
version: RegExp.$2,
guideline: RegExp.$3,
language: RegExp.$4
};
// the DTD
//this.dtd = somefuncttogetdtd();
}
}
};
[/CODE][CODE]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<script type="text/javascript" language="JavaScript" src="system.js"></script>
</head>
<body>
<span id="t1">Loading...</span><br />
<span id="t2">Loading...</span><br />
<span id="t3">Loading...</span>
<script type="text/javascript" language="JavaScript">
<!--
var tmp = 0;
function change(id) {
tmp++;
id = id + tmp;
document.getElementById(id).innerHTML = tmp + ' order - ' + arguments[1] + '<br>';
for (x = 0; x < 99999; x++) { }
}
function hey() {
alert('hello');
}
// Test Array before going into system object
var a = new Array();
a[0] = 1;
a.shift();
// Construct the system object
system.init();
// add functions to the queue:
// system.queue.add(funct, ownername, priority, [arg1], [arg2] ...);
// ownername is just a name of the function/code that made queue entry
// priority is a boolean value indicating where it is to be placed on queue:
// false = rear of queue(normal), true = front of queue(priority)
system.queue.add(change, 'wimpy', true, 't', 1);
system.queue.add(change, 'body', true, 't', 2);
system.queue.add(change, 'theman', false, 't', 3);
system.queue.add(hey);
// Process queue
// you can pass owner names to process to single those jobs out
// for immediate processing
system.queue.process();
// -->
</script>
</body>
</html>
[/CODE]if (!Array.shift) {
Array.prototype.shift = function() {
...
};
}Why are you testing a free format user definable field to decide what browser your visitor is using?[/QUOTE]
[/QUOTE]if (!Array.shift) {
[CODE]if (!Array().shift)
...[/CODE]or it may return undefined.if (!Array.[B]prototype.[/B]shift) {
Array.prototype.shift = function() {
...
};
}[CODE]
var tmp_args = Array.slice(arguments);
[/CODE]0.1.9 — BETA 6.17