can’t get this right

@chrismartzJun 19.2003

Could you please help me with this script and tell me why it doesn’t work:

<html>
<head>
<TITLE>Hope it works</TITLE>

</head>
<body bgcolor=”#FFFFFF” text=”#000000″ link=”#0000EE” vlink=”#551A8B”>
<script language=”javascript”>
<!–//
var channels = new Object();
channels[‘ANL’] = 15;

var channel_num = channels[ param(‘channel’) ];
if (channel_num == undefined)
alert(“error: invalid channel”);
else
window.location.href = channel_num + “.html”;
//–>
</script>
<a href=”http://americaspastime.tripod.com/trying/index.htm?page=ANL”>Works?</a>
</body>
</html>

My ~~[URL=website]~~http://americaspastime.tripod.com/trying/[/URL] is here.
-Thanks

to post a comment

JavaScript

18 Comments(s) _↴

@Khalid_AliJun 19.2003 — #The obvoius error would be here...

channels[ param('channel') ];

you have this object array channels and you are passing it a value

which should be returned vrom the function param('channel')

however I don't see a function named

param('channel')

in your code...

@chrismartzauthorJun 19.2003 — #I have this code which is suposed to work but it doesn't. Could someone help me. Here is the code:

***********************************************

<html>

<head>

<TITLE>Hope it works</TITLE>

</head>

<BODY bgcolor="#FFFFFF" text="#000000" link="#0000EE" vlink="#551A8B">

<script language="javascript">



</script>

<a href="http://americaspastime.tripod.com/trying/index.htm?channel=ANL">Works?</a>

</BODY>

</html>

***********************************************

If you can tell what is wrong, please help me. Your help will be greatly appreciated. Once I get this site done I will give you credit on my page. If you have a logo go ahead and put it in this forum

-Thank You

@JonaJun 19.2003 — #[font=arial][color=maroon]Take out the apostrophes in function params([b]'[/b]channel[b]'[/b]){ ... [/color][/font]

[b]Jona[/b]

@chrismartzauthorJun 19.2003 — #For some reason it still doesn't work. [URL=http://americaspastime.tripod.com/trying/]Here is the link to the page this is on.[/URL] I would really like to get this to work.

@Khalid_AliJun 19.2003 — #[b]Moderators Node[/b]

Mulitple posts for same topic is considered extremely rude,it overloads the resources as well as moderators time to delete/move/merge threads.

Please be carefull.

@jeffmottJun 19.2003 — #[size=2]channels[ANL] = 15;[/size]The ANL here [i]does[/i] require quotes.[size=2]channels[ param(channel) ][/size]You appear to be using the parameter parsing of the query string I provided, but I don't see where that code in the page. The channel inside param() here also needs to be quoted. The part that Jona was referring to is...[size=2]function param(channel){[/size]This is where the quotes needed to be removed, which you have done now. However, you have also given the function the same name as one for the parameter parsing routines. A more descriptive name might be something like change_channel[size=2]function change_channel(channel) {[/size]

@chrismartzauthorJun 19.2003 — #Alright, I made all the modifications I could and it still doesn't seem to be working. I had the .js file being called in the head section and also the body section. I am beginning to become frustrated. If you can help please do. I believe my code is alright but am not sure if the .js file should just be on the page.

@chrismartzauthorJun 19.2003 — #Also, am I supposed to modify the .js file that jeffmott created or just leave it alone.

@jeffmottJun 20.2003 — #[b]Alright, I made all the modifications I could and it still doesn't seem to be working[/b][/quote]You have your change_channel function, but don't appear to invoke it anywhere.[b]Also, am I supposed to modify the .js file that jeffmott created or just leave it alone[/b][/quote]You can leave it alone.

@chrismartzauthorJun 20.2003 — #what do you mean:[B]don't appear to invoke it anywhere[/B][/QUOTE] ????

@jeffmottJun 21.2003 — #A function doesn't execute until you call (invoke) that function. You've defined the function, but never call it. Thus it is never executed.

@chrismartzauthorJun 21.2003 — #okay, so would I put

<AHREF "http://americaspastime.tripod.com/trying/index.html?channel=ANL" onclick="change_channel()">Works?</a>

@JonaJun 21.2003 — #[font=arial][color=maroon]No, you would call it onload (<body onload="change_channel();">), unless there is a specific time when you want to get the channel.[/color][/font]

[b]Jona[/b]

@chrismartzauthorJun 21.2003 — #I would like to get in a link

@JonaJun 21.2003 — #[font=arial][color=maroon]Do it however you like. If it doesn't work, try something else.[/color][/font]

[b]Jona[/b]

@chrismartzauthorJun 21.2003 — #I know that, how would i call this in a link?

@JonaJun 21.2003 — #[font=arial][color=maroon]The same way you said in your post above.[/color][/font]

[b]Jona[/b]

@chrismartzauthorJun 21.2003 — #that way gives me the error from the else statement for some reason though. Have any other thoughts??

Also in #JavaScript _↴

Quick question which.element.length undefined for length 1?JS Form Handling

Success!

Help @chrismartz spread the word by sharing this article on Twitter...

Tweet This

can’t get this right

18 Comments(s) _↴

Also in #JavaScript _↴

Success!

Social

Version

can’t get this right

18 Comments(s) ↴

Also in #JavaScript ↴

Success!

The web is an endless sea of information. Don't miss the boat... Subscribe!

Social

Version

18 Comments(s) _↴

Also in #JavaScript _↴