Menu
Community /Pin to ProfileBookmark
@NogDogNov 01.2021 — #
PS: Untested!@NogDogNov 01.2021 — #And there's always the possibility (by no means a sure thing) that it's a "code smell" that might be avoided by thinking about why you're doing this, and if there's a better way than 3 different operations depending on which combination of things is set. It may, in fact, be the "best" way; but not knowing what's actually going on in detail, I can't be positive. :)
Simplified If Statement
I’ve got a form where I’m doing something based on if two fields were filled out. I’ll refer to these fields as FieldA and FieldB.
What I’m need to do is run a code if both are filled out, another if FieldA is filled only and a third if FieldB is fillled out. If neither are filled out do nothing.
I’m thinking of the following.
I’ve not tested this, but is the best way to do it?
[code]
if (!empty($_POST[‘FieldA’]) && !empty($_POST[‘FieldB’])){
// Both Filled Out
} elseif (!empty($_POST[‘FieldA’]) && empty($_POST[‘FieldB’])){
/// Only Field A Filled Out
} elseif (empty($_POST[‘FieldA’]) && !empty($_POST[‘FieldB’])){
// Only Field B filled out
}
Sign in
to post a comment6 Comments(s) ↴
0
@NogDogNov 01.2021 — #switch[code=php]
switch(post_a_or_b('FieldA', 'FieldB')) {
case 'both':
// do stuff with both
break;
case 'a':
// do stuff with a;
break;
case 'b':
// do stuff with b;
break;
case 'neither':
// nothing to do?
break;
default:
// throw Exception???
}
function post_a_or_b($a, $b) {
$cases = ['neither', 'b', 'a', 'both'];
return($cases[2 * !empty($_POST[$a]) + !empty($_POST[$b])]);
}
[/code]PS: Untested!
0
@NogDogNov 01.2021 — #And there's always the possibility (by no means a sure thing) that it's a "code smell" that might be avoided by thinking about why you're doing this, and if there's a better way than 3 different operations depending on which combination of things is set. It may, in fact, be the "best" way; but not knowing what's actually going on in detail, I can't be positive. :)